chrome auto fill fix #640
Open
chrome auto fill fix #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what was fixed: Fixed the issue where because of how google chrome initially autofills fields where the browser saved data, for example "email" and "password"
Problem: initially the onchange event is not triggered if the user loads the page from the URL, or refreshes the page. this problem does not happen if they have being actively using the website, and navigated to page with the form that holds autofilled data
example image of problem on first load: https://drive.google.com/file/d/1efej3r7PnD17tJugxMHI4OqivTKGOmZY/view?usp=sharing
example image after solution from this PR on first load: https://drive.google.com/file/d/1GG79hDE77ebtXdxRqPPbmAz0CMGg0E5T/view?usp=sharing
already recorded issue that could not have been resolved before, but can be resolved now, if only slightly: #210