Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bare.css export to snackbar package #512

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leonhma
Copy link

@leonhma leonhma commented Sep 24, 2022

As it stands bare.css is not exported from the snackbar package. You have to manually change this file after every yarn/yarn add. Please get this released ASAP

@hperrin
Copy link
Owner

hperrin commented Apr 3, 2023

Is this needed because you're importing it from JS? I'm a little confused why you would need it to be exported here.

@leonhma
Copy link
Author

leonhma commented May 30, 2023

Sorry to take so long to repond. Seems I have missed the notification.

Yes. In order to only import the relevant styles and because I didn't have a theme set up, I imported the styles straight from JS. This worked perfectly for all other modules, but not for the snackbar. What I did fixed it. The project kind of found it's way into the abandoned projects bin so it's not a feature I need anymore.

Feel free to close this if you don't want to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants