also compile Lmod spider cache with alternate Lua versions (+ update to Lmod 8.4.10) (HPC-8637) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itkovian
reviewed
Oct 26, 2020
| Version: 8.4.2 | ||
| Release: 1.ug%{?dist} | ||
| Version: 8.4.10 | ||
| Release: 2.ug%{?dist} |
There was a problem hiding this comment.
Why bump both the version and the release?
There was a problem hiding this comment.
because I built an RPM with a .1 release number while testing, but then had to make another minor change (see 990f15e)
Lmod-8.4.10-2.ug.el7.x86_64 is currently what's installed on gligar06
itkovian
reviewed
Oct 26, 2020
Lmod-UGent.spec
Outdated
| @@ -99,6 +101,9 @@ rm -rf %{buildroot} | |||
|
|
|||
|
|
|||
| %changelog | |||
| * Mon Oct 26 2020 Kenneth Hoste <kenneth.hoste@ugent.be> - 8.4.10-1.ug | |||
There was a problem hiding this comment.
This does not match the above release?
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested on
gligar06(both re-generating Lmod cache + Lmod update), works like charmsee also TACC/Lmod#475