Support Tron network #278
Open
Support Tron network #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joeky <joeky5888@gmail.com>
Signed-off-by: Joeky <joeky5888@gmail.com>
Signed-off-by: Joeky <joeky5888@gmail.com>
Signed-off-by: Joeky <joeky5888@gmail.com>
Signed-off-by: Joeky <joeky5888@gmail.com>
Signed-off-by: Joeky <joeky5888@gmail.com>
Signed-off-by: Joeky <joeky5888@gmail.com>
Signed-off-by: Joeky <joeky5888@gmail.com>
Signed-off-by: Joeky <joeky5888@gmail.com>
Signed-off-by: Joeky <joeky5888@gmail.com>
Signed-off-by: Joeky <joeky5888@gmail.com>
howardwu
requested changes
Feb 4, 2022
There was a problem hiding this comment.
Change requests:
- Can you utilize the Ethereum types for Tron where they overlap? For example, one can define the TronAmount as EthereumAmount as follows:
pub type TronAmount = EthereumAmount;- Can you confirm the mnemonics are different in Tron than Ethereum?
Since Tron is a shameless clone of Ethereum, I believe you can share many of the resources, structs, and methods provided from the Ethereum implementation here.
wagyu/cli/tron.rs
Outdated
Comment on lines
844
to
852
| // "chinese_simplified" => output::<TronMainnet, ChineseSimplified>(options), | ||
| // "chinese_traditional" => output::<TronMainnet, ChineseTraditional>(options), | ||
| // "english" => output::<TronMainnet, English>(options), | ||
| // "french" => output::<TronMainnet, French>(options), | ||
| // "italian" => output::<TronMainnet, Italian>(options), | ||
| // "japanese" => output::<TronMainnet, Japanese>(options), | ||
| // "korean" => output::<TronMainnet, Korean>(options), | ||
| // "spanish" => output::<TronMainnet, Spanish>(options), | ||
| // _ => output::<TronMainnet, English>(options), |
| @@ -9,6 +9,7 @@ pub extern crate wagyu_ethereum as ethereum; | |||
| pub extern crate wagyu_model as model; | |||
| pub extern crate wagyu_monero as monero; | |||
| pub extern crate wagyu_zcash as zcash; | |||
| pub extern crate wagyu_tron as tron; | |||
There was a problem hiding this comment.
nit: please order alphabetically
wagyu/main.rs
Outdated
| @@ -6,6 +6,7 @@ use wagyu::cli::bitcoin::BitcoinCLI; | |||
| use wagyu::cli::ethereum::EthereumCLI; | |||
| use wagyu::cli::monero::MoneroCLI; | |||
| use wagyu::cli::zcash::ZcashCLI; | |||
| use wagyu::cli::tron::TronCLI; | |||
There was a problem hiding this comment.
nit: please order alphabetically
| @@ -27,6 +28,7 @@ fn main() -> Result<(), CLIError> { | |||
| EthereumCLI::new(), | |||
| MoneroCLI::new(), | |||
| ZcashCLI::new(), | |||
| TronCLI::new(), | |||
There was a problem hiding this comment.
nit: please order alphabetically
| @@ -36,6 +38,7 @@ fn main() -> Result<(), CLIError> { | |||
| ("ethereum", Some(arguments)) => EthereumCLI::print(EthereumCLI::parse(arguments)?), | |||
| ("monero", Some(arguments)) => MoneroCLI::print(MoneroCLI::parse(arguments)?), | |||
| ("zcash", Some(arguments)) => ZcashCLI::print(ZcashCLI::parse(arguments)?), | |||
| ("tron", Some(arguments)) => TronCLI::print(TronCLI::parse(arguments)?), | |||
There was a problem hiding this comment.
nit: please order alphabetically
tron/src/private_key.rs
Outdated
|
|
||
| /// Returns a randomly-generated Tron private key. | ||
| fn new<R: Rng>(rng: &mut R) -> Result<Self, PrivateKeyError> { | ||
| // let random: [u8; 32] = rng.gen(); |
README.md
Outdated
| - [3.1.2 Ethereum](#312-ethereum) | ||
| - [3.1.3 Monero](#313-monero) | ||
| - [3.1.4 Zcash](#314-zcash) | ||
| - [3.1.5 Tron](#315-tron) |
There was a problem hiding this comment.
nit: please order alphabetically
Cargo.toml
Outdated
| @@ -24,7 +24,7 @@ name = "wagyu" | |||
| path = "wagyu/main.rs" | |||
|
|
|||
| [workspace] | |||
| members = [ "bitcoin", "ethereum", "model", "monero", "zcash" ] | |||
| members = [ "bitcoin", "ethereum", "model", "monero", "zcash", "tron" ] | |||
There was a problem hiding this comment.
nit: please order alphabetically
| @@ -39,6 +39,7 @@ wagyu-ethereum = { path = "./ethereum", version = "0.6.3" } | |||
| wagyu-model = { path = "./model", version = "0.6.3" } | |||
| wagyu-monero = { path = "./monero", version = "0.6.3" } | |||
| wagyu-zcash = { path = "./zcash", version = "0.6.3" } | |||
| wagyu-tron = { path = "./tron", version = "0.6.3" } | |||
There was a problem hiding this comment.
nit: please order alphabetically
Cargo.toml
Outdated
| @@ -57,9 +58,10 @@ serde_json = { version = "1.0" } | |||
| tiny-keccak = { version = "1.4" } | |||
|
|
|||
| [profile.release] | |||
| opt-level = 3 | |||
| opt-level = "z" | |||
There was a problem hiding this comment.
Can you help me understand the purpose of changing opt-level and codegen-units here?
Signed-off-by: Joeky <joeky5888@gmail.com>
As much as I understand your stand on DRY (don't repeat yourself). Here are some thoughts, I would like to keep them independent.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started out quite a while ago, I think it's time for contributing.
With this PR wagyu can generate or import standard/HD trx/trc20 wallets. However, tron transaction isn't implemented yet.