Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rapid to v2.3.1 from v2.2.5 #6202

Merged
merged 2 commits into from
May 30, 2024

Conversation

tsmock
Copy link
Contributor

@tsmock tsmock commented Jan 16, 2024

There are fairly minimal changes required for this to work.

About the only thing of note is Rapid requires node 18 or later. Setting the NODE_OPTIONS=--openssl-legacy-provider environment variable will work around the following issue (see #6053):

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:69:19)
    at Object.createHash (node:crypto:133:10)
    at module.exports (frontend/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (frontend/node_modules/webpack/lib/NormalModule.js:417:16)
    at frontend/node_modules/webpack/lib/NormalModule.js:452:10
    at frontend/node_modules/webpack/lib/NormalModule.js:323:13
    at frontend/node_modules/loader-runner/lib/LoaderRunner.js:367:11
    at frontend/node_modules/loader-runner/lib/LoaderRunner.js:233:18
    at context.callback (frontend/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at frontend/node_modules/react-scripts/node_modules/babel-loader/lib/index.js:59:103 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'

This depends upon moving to node 18 (see #5908).

EDIT: We are now on node 18.

@github-actions github-actions bot added scope: frontend dependencies Pull requests that update a dependency file javascript labels Jan 16, 2024
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@varun2948
Copy link
Contributor

@tsmock how can we go ahead on this PR ?

@tsmock
Copy link
Contributor Author

tsmock commented May 2, 2024

@varun2948 : If you don't mind the failing frontend-code-test job, yes.

I think it should have been fixed by #6397. I did just rebase, and it is still failing.

EDIT: It looks like I didn't wait long enough for the job to get picked up and looked at the older run.

@tsmock tsmock force-pushed the feature/rapid-update branch 2 times, most recently from 2417cdc to ecc6b22 Compare May 7, 2024 13:53
@tsmock tsmock changed the title Update Rapid to v2.2.4 from v2.1.x Update Rapid to v2.2.5 from v2.1.x May 7, 2024
@ramyaragupathy
Copy link
Member

Next steps here is testing on dev server. Prioritising this for next release @royallsilwallz @manjitapandey @varun2948

@ramyaragupathy ramyaragupathy added status: testing Does it really work or is it pretending to work? upcoming release 🔜 labels May 8, 2024
@ramyaragupathy ramyaragupathy added this to the v4.7.3 milestone May 8, 2024
@manjitapandey
Copy link

Found few errors on testing:
Uploading of edits failed: An unknown crash occurs when trying to upload the edits on rapid editor.
Steps to reproduce

  • Draw few features using rapid editor.
  • Click on save to upload the features on osm.
  • See error.
    image

Refresh the page to get upload page on left panel. 404 error pop-up is seen.
image

@tsmock tsmock force-pushed the feature/rapid-update branch 2 times, most recently from fc33983 to 90eea50 Compare May 13, 2024 14:20
@tsmock tsmock changed the title Update Rapid to v2.2.5 from v2.1.x Update Rapid to v2.3.1 from v2.1.x May 13, 2024
@tsmock
Copy link
Contributor Author

tsmock commented May 13, 2024

@manjitapandey : That should be fixed now.

@royallsilwallz
Copy link
Contributor

hey @tsmock, can you rebase to the latest develop branch and push?

Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@royallsilwallz
Copy link
Contributor

The version upgrade will be from v2.2.5 to v2.3.1 since rapid got accidently upgraded to v2.2.5 in this PR during yarn lock generation.

@ramyaragupathy ramyaragupathy changed the title Update Rapid to v2.3.1 from v2.1.x Update Rapid to v2.3.1 from v2.2.5 May 23, 2024
@ramyaragupathy
Copy link
Member

From @manjitapandey on slack:

I was testing the Rapid version upgrade PR on Naxa server. Everything works fine except I can't see microsoft buildings and facebook roads which are available on same area in rapid website.
The next step we are thinking is to merge the PR on HOT dev server and test it again before the release.

@ramyaragupathy ramyaragupathy merged commit c2192a5 into hotosm:develop May 30, 2024
6 of 7 checks passed
@tsmock tsmock deleted the feature/rapid-update branch May 30, 2024 12:53
@ramyaragupathy ramyaragupathy mentioned this pull request Jun 4, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file external tools priority: high Rapid scope: frontend status: testing Does it really work or is it pretending to work? upcoming release 🔜
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants