Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max retries for auto applying addon image fixup #5051

Merged
merged 2 commits into from May 22, 2024

Conversation

mdegat01
Copy link
Contributor

Proposed change

If the addon image repair fixup fails 5 times then it stops being auto-applied. At this point we assume this cannot be fixed automatically and requires manual intervention so we stop using resources pulling/building the image and failing.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the refactor A code change that neither fixes a bug nor adds a feature label Apr 30, 2024
@home-assistant home-assistant bot marked this pull request as draft May 1, 2024 08:57
@home-assistant
Copy link

home-assistant bot commented May 1, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@mdegat01 mdegat01 force-pushed the max-retries-no-image-fixup branch from d933c20 to 5acc033 Compare May 21, 2024 20:55
@mdegat01 mdegat01 marked this pull request as ready for review May 21, 2024 20:55
@home-assistant home-assistant bot requested a review from agners May 21, 2024 20:55
@agners agners merged commit eca99b6 into main May 22, 2024
19 checks passed
@agners agners deleted the max-retries-no-image-fixup branch May 22, 2024 09:54
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants