Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a foreground service for reliable background transmitting #4347

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dshokouhi
Copy link
Member

Summary

Hopefully fixes: #3159 by implementing a similar foreground service like in #3369 based on the docs to create a "fake" scanner that looks for nothing to help keep the transmitter alive.

Needs end user testing. 馃

Screenshots

image

image

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#pending

Any other notes

Code may not look pretty for now but wanted to get end user feedback

@jpelgrom
Copy link
Member

Maybe it's good to split the Bluetooth scan permission into its own PR which we can quickly approve+merge as that fixes an obvious oversight/bug, whereas the foreground service is an effort to improve things but also introduces new behavior?

@dshokouhi
Copy link
Member Author

Maybe it's good to split the Bluetooth scan permission into its own PR which we can quickly approve+merge as that fixes an obvious oversight/bug, whereas the foreground service is an effort to improve things but also introduces new behavior?

actually the scan permission is required in this PR because we are now using the scanner in this sensor where we were not before

@jpelgrom
Copy link
Member

I missed that's new, sorry. In that case never mind and let's wait for positive results.

@dshokouhi
Copy link
Member Author

Agreed this requires end users to confirm its working for them as I cannot reproduce

@dshokouhi dshokouhi marked this pull request as draft April 19, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android iBeacon transmission stops shortly after started
2 participants