New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[for discussion] Use OkHttp 5 #4023
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
if (cookieManager != null) { | ||
builder.cookieJar(CookieJarCookieManagerShim()) | ||
|
||
val isWear = appContext.packageManager.hasSystemFeature(PackageManager.FEATURE_WATCH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should probably split this out. Let me know if you want it separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Use OkHttp5, while alpha it is production quality, but new API are not stable.
But critically it includes support for a simplified form of Happy Eyeballs, avoiding issues on IPv6 networks.
See https://www.reddit.com/r/RedditEng/comments/v1upr8/ipv6_support_on_android/
No offense if this is too soon. Please close the PR if so.
Screenshots
N/A
Link to pull request in Documentation repository
N/A
Any other notes
N/A