Android Automotive Module #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
Github actions for PR require this to be set up in order for the build to pass.
We add 2 because the app, wear (+1) and automotive versions need to have different version codes.
googlvalenzuela
changed the title
/home/runner/work/android/android/app/src/main/java/io/homeassistant/companion/android/BaseActivity.kt:19:1 Needless blank line(s) /home/runner/work/android/android/app/src/main/java/io/homeassistant/companion/android/BaseActivity.kt:31:95 Unnecessary semicolon /home/runner/work/android/android/app/src/main/java/io/homeassistant/companion/android/BaseActivity.kt:39:1 Unexpected blank line(s) before "}" /home/runner/work/android/android/app/src/main/java/io/homeassistant/companion/android/BaseActivity.kt:44:1 First line in a method block should not be empty
JBassett
requested changes
Mar 24, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Another thing, in the |
|
@JBassett let me know if there is anything else I can do to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Creation of Android Automotive Module in order to compile and deploy home assistant into Android Automotive following
https://developer.android.com/training/cars/apps/automotive-os
Update Base Activity to be able to transition from Full activity to Car App library.
No real changes on the app looks / interactions, this will launch Android Automotive Car App Activity as the launcher and its following the same execution path that is today for Android Auto.
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Android Automotive IOT documentation: https://developer.android.com/training/cars/apps/automotive-os
Any other notes