Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier --cache-location=.prettier-cache #6634

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cdeil
Copy link
Contributor

@cdeil cdeil commented Apr 1, 2024

I had a second node_modules folder which I found confusing.

Apparently not possible to get rid of it yet ( see prettier/prettier#13032 ) but hopefully this will hide it by default.

(panel_dev) panel $ find node_modules 
node_modules
node_modules/.cache
node_modules/.cache/prettier
node_modules/.cache/prettier/.prettier-caches
node_modules/.cache/prettier/.prettier-caches/04d07533a4dc0e8ecb9ce9c6af0f582956b2ce4e.json
(panel_dev) panel $ cat node_modules/.cache/prettier/.prettier-caches/04d07533a4dc0e8ecb9ce9c6af0f582956b2ce4e.json
{"94c70838f6582b402d2ca1fde8f428df7f5e08cd":{"files":{"panel/template/editable/editable.css":["yz8jN6B7lUkpjFh2nKEVy+9iT/4=",true],"panel/template/golden/golden.css":["SiKhDdTeMkMO8hoeFeehET9DBRw=",true],"panel/template/slides/slides.css":["SciHvduYS0tsgK2nOAcWTGctA10=",true],"panel/dist/css/notifications.css":["7aqHRKysbj5sZpqC+y6wRnFeqA8=",true],"panel/dist/css/button.css":["NZEetSRtHRh437lV1n9GDfk9k1U=",true],"panel/template/react/react.css":["wFSSv4cOY+Svl4xCqIZUV6KYnVI=",true],"panel/dist/css/markdown.css":["GQcbnFTW6AU99sTXYMpmGKdb+24=",true]},"modified":1711986814648}}%                                                                                                                                                                             

@hoxbro
Copy link
Member

hoxbro commented Apr 2, 2024

This is because pre-commit uses the latest version regardless if it is a pre-release. And this version right now creates a node_modules folder

Can you try downgrading the version to v3.1.0 and see if the problem is still there?

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@hoxbro
Copy link
Member

hoxbro commented May 7, 2024

Related issue: holoviz/holoviews#6219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants