Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display value for player #6059

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

benbarn313
Copy link
Contributor

player.demo.mp4

PR closes issue #229

Added display value for the Player widget
Added the param "value_location" to the Slider, which sets where the value is displayed

Planning on adding support for the Name param as well

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0824f9c) 82.98% compared to head (c49d092) 83.91%.
Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6059      +/-   ##
==========================================
+ Coverage   82.98%   83.91%   +0.92%     
==========================================
  Files         295      300       +5     
  Lines       44038    44700     +662     
==========================================
+ Hits        36543    37508     +965     
+ Misses       7495     7192     -303     
Flag Coverage Δ
ui-tests 40.20% <100.00%> (+2.04%) ⬆️
unitexamples-tests 72.19% <25.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Untitled.ipynb Outdated Show resolved Hide resolved
panel/widgets/player.py Outdated Show resolved Hide resolved
panel/widgets/player.py Outdated Show resolved Hide resolved
panel/models/widgets.py Outdated Show resolved Hide resolved
panel/models/player.ts Outdated Show resolved Hide resolved
panel/models/player.ts Outdated Show resolved Hide resolved
@benbarn313 benbarn313 closed this Dec 19, 2023
@benbarn313 benbarn313 reopened this Dec 19, 2023
@benbarn313 benbarn313 marked this pull request as ready for review December 19, 2023 02:14
@benbarn313
Copy link
Contributor Author

@philippjfr can you take a look at this?

panel/models/widgets.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ahuang11 ahuang11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! You're becoming the Player* expert!

Lots of people will appreciate this feature :)

panel/widgets/player.py Outdated Show resolved Hide resolved
panel/widgets/player.py Outdated Show resolved Hide resolved
panel/widgets/player.py Show resolved Hide resolved
formatting changes

Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
@philippjfr
Copy link
Member

This is looking great! In practice we mostly use DiscretePlayer and there we don't currently have the corresponding labels available in the frontend right? So I think we have to add (optional) support for sending a list of string labels which will be displayed instead of the Player index.

panel/models/player.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants