Fix pandas warning when sorting filtered tabulator #6036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to pass a function as a filter to tabulator but passing a functools.partial function currently fails. This update allows to pass both regular and partial function
When a Tabulator with applied filter(s) is sorted the code yields a warning from pandas "A value is trying to be set on a copy of a slice from a DataFrame". This changes fixes the ussie by first sorting Tabulator data and then applying filter. Alternative is to create a copy of passed dataframe to _sort_df function.
When some of selected rows are filtered out in Tabulator calling selected_dataframe() raises error. This change makes the function to return all selected rows.
|
If you look to my branch I made a second commit fixing a bug in Tabulator selected_dataframe function. I tried to create two separate pull requests but it seems that I can create only single request for all my changes. |
|
@TBym - do you have a minimal reproducer for the warning and issue you were getting? Is the issue resolved in the meantime? There have been a few tabulator fixes in the meantime, wee https://holoviz-dev.github.io/panel/about/releases.html or try with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Tabulator with applied filter(s) is sorted the code yields a warning from pandas "A value is trying to be set on a copy of a slice from a DataFrame".
This changes fixes the ussie by first sorting Tabulator data and then applying filter. Alternative is to create a copy of passed dataframe to _sort_df function.