Clear selection if value change from pagination=remote
#6008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
added
type: bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6008 +/- ##
==========================================
+ Coverage 84.45% 84.67% +0.22%
==========================================
Files 291 291
Lines 43544 43820 +276
==========================================
+ Hits 36774 37105 +331
+ Misses 6770 6715 -55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ahuang11
reviewed
Dec 12, 2023
philippjfr
reviewed
Jan 12, 2024
| @@ -1562,6 +1562,11 @@ def _update_max_page(self): | |||
| for ref, (model, _) in self._models.items(): | |||
| self._apply_update([], {'max_page': max_page}, model, ref) | |||
|
|
|||
| @param.depends("value", watch=True) | |||
| def _clear_selection_remote_pagination(self): | |||
There was a problem hiding this comment.
Think this may have to be a watcher that checks if event.new is not event.old.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the value of the Tabulator changes, we can no longer trust the selection; therefore, we clear it.