-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ImageStack in dynspread #6024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6024 +/- ##
===========================================
+ Coverage 17.43% 88.39% +70.95%
===========================================
Files 323 323
Lines 67588 67621 +33
===========================================
+ Hits 11784 59771 +47987
+ Misses 55804 7850 -47954 ☔ View full report in Codecov by Sentry. |
Glad to see that the current codepath in datashader seems to work! Two things to note:
While the first thing would be good to check before merging this PR, the second thing is a fair bit more work and can be made into a feature request and addressed in a future PR. |
@philippjfr: "To efficiently spread multiple layers, we may have to do this in Datashader" |
I will add a small test and then merge this. We can always improve functionality later. |
Resolves #5993
screenrecord-2023-12-11_11.56.54.mp4