Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't distribute /examples twice #5632

Closed
wants to merge 1 commit into from
Closed

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Mar 1, 2023

I haven't yet figured out how to solve this. It's not a major issue anyway for HoloViews, but it's a sign that something is wrong in how it's packages. I've asked a question there to try to get more info pypa/setuptools#3841. It's likely we'll need to update pyctdev not to run python setup.py ... anymore, it's unrelated to this though (I think) as I've been able to reproduce the issue running python -m build to build the sdist and wheel.

@maximlt maximlt marked this pull request as draft March 1, 2023 14:10
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Merging #5632 (f6fa216) into main (029ba95) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5632   +/-   ##
=======================================
  Coverage   88.26%   88.26%           
=======================================
  Files         302      302           
  Lines       62514    62514           
=======================================
  Hits        55180    55180           
  Misses       7334     7334           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants