This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Intra-conductor link propagation #2043
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app_spec/test/files/links.js
Outdated
| ) | ||
|
|
||
| const posts2 = await alice.call('app2', 'simple', 'get_my_links', | ||
| { base: alice.info('app2').agentAddress, status_request: 'Live' } |
There was a problem hiding this comment.
Hey just trying to figure out what is happening because I wanted to take a look at it.
Should this be alice.info('app1').agentAddress? only asking because at this point we wont receieve any results from posts1 or posts2 because the link was created with a different agentAddress.
Context : tried printing out the addresses of these two agent addresses and are the same
There was a problem hiding this comment.
omg...yes it should be. I just fixed it, let's see what the test says now..
|
Turns out it works just fine 🤦♂️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Adds a test that demonstrates whether or not links can propagate between instances of the same DNA on a single conductor. The viability of writing in-memory tests, and scaled up final-exam tests, relies on this result.
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation