Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable config file path #142

Open
wants to merge 3 commits into
base: 3.0-pre
Choose a base branch
from

Conversation

samuelmasuy
Copy link

I am using XDG user directories convention in order to keep my home directory as clean as possible. In that fashion, I want the shpotify config file to be under ~/.config/shpotify/ instead of my home directory.

Should SHPOTIFY_CONFIG_FILE be defined, its value will be used instead of ${HOME}/.shpotify.cfg

@hnarayanan hnarayanan changed the base branch from master to 3.0-pre September 27, 2020 21:02
@hnarayanan
Copy link
Owner

Thank you! Could you rename the variable name you've changed back to USER_CONFIG_DEFAULTS. This way I can clearly see what the actual change your PR is introducing.

Also, could you make it so that it is easy to merge this into the 3.0-pre branch? There are so many open PRs I am going to try to merge them all into one experimental development branch and try out all the features in one go.

@samuelmasuy
Copy link
Author

Thank you! I've renamed the variables, making it a one line change. I've also rebased on 3.0-pre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants