Fix resource leaks #243
Open
Fix resource leaks #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 18, 2024 12:22
(cherry picked from commit 61b22d2b17864ded5ae47a94271f0dfa7013358b)
(cherry picked from commit e63ee22b19a35d1832274be67b1846e7dac69f98)
(cherry picked from commit 0f2d19eb155f576660822ba0525fca5061548fb3)
…edWmi block was not entered (cherry picked from commit 384f89a64a31b669797f4c06e806499a75d85182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found two places in the code where resources are not released correctly.
It is possible to revert the deletion of
SAFE_RELEASE(pCOMDev);from line 64 if you believeVariantInit,VariantClearorIWbemClassObject::Getcould throw an exception that would skip over line 56.EDIT: I have found two more places where resources can be leaked.