Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Add ZFS cache awareness to memory meters. #976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zielmicha
Copy link

@zielmicha zielmicha commented Jan 11, 2020

Fixes #44

This is #153, but rebased to be mergable with the current head.

Enable with --enable-zfs-cache-awareness

(Only tested with ZFS on linux)
@natoscott
Copy link
Collaborator

@zielmicha I believe this PR will need to be reworked to fit in with the code from #920

It should simplify the changes needed here immensely - the arcstats file parsing is done and there's no need for configure.ac changes, so most of this PR goes away (put not all AFAICT).

We're creating a community 3.0.0 htop release, it'd be great to have this functionality included for Linux ZFS.
[ https://github.com//issues/992 ]

I notice the FreeBSD code (freebsd/FreeBSDProcessList.c) already handles the memory accounting adjustments you're making here - but from my understanding of the code in both PRs, I believe the functionality you seek here will still be missing for Linux.

Please see https://github.com/htop-dev/htop for a tree with #920 merged - if someone with ZFS filesystems could create a new PR ASAP for the htop-dev repo, it'd be great to include this in that new release. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZFS buffer/cache is counted under used memory
3 participants