Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zinc to 1.4.0 #290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jroylance
Copy link

No description provided.

rules/scala/workspace.bzl Outdated Show resolved Hide resolved
rules/scala/workspace.bzl Show resolved Hide resolved
@jroylance jroylance force-pushed the jroylance-upgrade-zinc-to-1-4-0 branch from 1f1520a to 9d24039 Compare October 29, 2020 17:20
@SrodriguezO
Copy link
Collaborator

Builds are failing: https://travis-ci.org/github/higherkindness/rules_scala/builds/739988853

The status doesn't on the PR update cause of #288... I'll reach out to James to see if we can get that taken care of

@timothyklim
Copy link
Contributor

Version 1.4.0 has breaking changes:

  • VirtualFile and VirtualFileRef instead of Path;
  • compiler-bridge.jar must contain META-INF/services/xsbti.compile.CompilerInterface2 or it will throw NPE because of switching to legacy xsbti.CompilerInterface which not available in classpath;
  • No ScalaPB for sbt internal messages! Only messages from shaded google protobuf package.

I have a fork (https://github.com/TimothyKlim/rules_scala/pull/1/files) which I'm using to upgrade zinc to 1.4.2, drop old scala versions and add scala 3.0.

@jroylance
Copy link
Author

Awesome. @timothyklim do you have plans to merge your fork back here once it's working?

@timothyklim
Copy link
Contributor

Now I can build and test my project with this commit.
You can cherry-pick changes that you need to continue backwards compatibility, I have my fork to have ability to move fast and break things until I'll port rest things to get rid of sbt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants