Archived tasks that are trimmed from the set are deleted #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harrison-Miller
changed the title
|
Depends on #441 |
This was referenced Feb 20, 2024
This was referenced Mar 29, 2024
| local extra = redis.call("ZRANGE", KEYS[4], 0, -ARGV[5]) | ||
| if #extra > 0 then | ||
| for _, id in ipairs(extra) do | ||
| redis.call("DEL", KEYS[9] .. id) |
There was a problem hiding this comment.
Ideally, we need to raise the maxArchiveSize or make it settable before calling delete here. In a scenario where tasks are failing and reaching max retries fast, it will just keep clearing them from the queue before allowing for manual intervention.
I see it is being tracked in #534 already :)
kamikazechaser
approved these changes
May 7, 2024
|
When will this pull request be merged? |
|
I will try and work on the suggestion in the next few weeks. |
|
@kamikazechaser nvm it took 3 seconds to change, confirmed the tests I added still pass. Anything else you need changed? |
No, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the issue outlined in: #730
You can confirm the test case/fix is working by deleting lines: 852/860 in rdb.go of the fix branch to observe the old failure.