HV-1971 fix CNPJ validation when all digits are the same

[edurbs]

https://hibernate.atlassian.net/browse/HV-1971

[hibernate-github-bot]

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

[marko-bekhta]

Hey, thanks for reporting the problem and submitting a PR. Please see an inline comment.

[marko-bekhta]

Maybe let's replace this with a simple for loop? Something along the lines:

// the number is too short, hence it's invalid anyway:
if ( value.length() < 2 ) {
	return false;
}

char firstDigit = value.charAt( 0 );
char otherDigit = value.charAt( 1 );
for ( int i = 2; i < value.length(); i++ ) {
	char c = value.charAt( i );
	if ( Character.isDigit( c ) && firstDigit != c ) {
		otherDigit = c;
	}
}
if ( firstDigit == otherDigit ) {
	return false;
}

From what I see distinct may not be optimized:

public final IntStream distinct() {
	// While functional and quick to implement, this approach is not very efficient.
	// An efficient version requires an int-specific map/set implementation.
	return boxed().distinct().mapToInt(i -> i);
}

[edurbs]

perfect, I'll change it. Thanks!

[marko-bekhta]

Looks good, thanks!