Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HV-1921 Create a tester library for constraint validators with dependency injection #1281

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shark300
Copy link

@Hibernate-CI
Copy link
Contributor

Can one of the admins add this person to the trusted builders? (reply with: "add to whitelist" or "ok to test")

@gsmet
Copy link
Member

gsmet commented Aug 4, 2022

Hey, just a note that I have seen this PR. I have to think a bit about it, especially about where it's best to document this.

@shark300
Copy link
Author

shark300 commented Aug 4, 2022

Hi @gsmet , thank you so much for your message.

"I have to think a bit about it"
To be honest I have already used a similar way to test custom validators in some Spring Boot apps because the unit testing of validators is one of the most effective ways and it is mentioned on the website of Hibernate Validator.
I had some ideas related to the injection (to inject dependencies instead of mocking the whole custom validator) but I did not want to repeat the authors of Spring (DRY).

"especially about where it's best to document this."
Yes, I totally agree with you. It was a little bit challenging to find a place for this feature...

@shark300
Copy link
Author

shark300 commented Oct 3, 2022

Hi @gsmet,
Do you have any updates regarding to this PR?

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Oct 3, 2022

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants