HBX-2780: Create Interface for TableFilterWrapper #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new utility class 'org.hibernate.tool.orm.jbt.internal.util.TypeFactoryWrapperHelper' - Add new test class 'org.hibernate.tool.orm.jbt.internal.util.TypeFactoryWrapperHelperTest' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Create new initial test class 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest' - Create new initial interface class 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper' - Create new factory class 'org.hibernate.tool.orm.jbt.internal.factory.TypeFactoryWrapperFactory' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetBooleanType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getBooleanType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetByteType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getByteType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetBigIntegerType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getBigIntegerType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetShortType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getShortType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetShortType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getShortType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetCalendarDateType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getCalendarDateType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetIntegerType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getIntegerType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetBigDecimalType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getBigDecimalType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetCharacterType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getCharacterType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetClassType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getClassType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetCurrencyType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getCurrencyType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetDateType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getDateType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetDoubleType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getDoubleType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetFloatType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getFloatType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetLocaleType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getLocaleType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetLongType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getLongType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetStringType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getStringType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetTextType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getTextType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetTimeType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getTimeType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetTimestampType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getTimestampType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetTimezoneType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getTimezoneType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetTrueFalseType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getTrueFalseType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetYesNoType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getYesNoType()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Refactor class 'org.hibernate.tool.orm.jbt..internal.util.TypeFactoryWrapperHelper' into 'org.hibernate.tool.orm.jbt..internal.util.TypeRegistry' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Refactor class 'org.hibernate.tool.orm.jbt..internal.util.TypeFactoryWrapperHelper' into 'org.hibernate.tool.orm.jbt..internal.util.TypeRegistry' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.internal.util.TypeRegistryTest#testGetType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.TypeRegistry#getType(String)' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Fold uses of 'org.hibernate.tool.orm.jbt.internal.util.TypeRegistry#typeRegistry().getType(String)' into 'org.hibernate.tool.orm.jbt.internal.util.TypeRegistry#getType(String)' - Remove unneeded method 'org.hibernate.tool.orm.jbt.internal.util.TypeRegistry#typeRegistry()' - Remove unneeded test 'org.hibernate.tool.orm.jbt.internal.util.TypeRegistryTest#testTypeRegistry()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Modify 'org.hibernate.tool.orm.jbt.internal.util.TypeRegistry#getType(String)' to perform lookup in BasicTypeRegistry and add the new TypeWrapper if the Type exists Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetBasicType()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getBasicType(String)' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Refactor initialization of class 'org.hibernate.tool.orm.jbt.TypeRegistry' - Add new test case 'org.hibernate.tool.orm.jbt.internal.util.TypeRegistryTest#testGetTypeFormats()' - Implement new method 'org.hibernate.tool.orm.jbt.internal.util.TypeRegistry#getTypeFormats()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
- Add new test case 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapperTest#testGetTypeFormats()' - Add new default interface method 'org.hibernate.tool.orm.jbt.api.TypeFactoryWrapper#getTypeFormats()' Signed-off-by: Koen Aers <koen.aers@gmail.com>
koentsje
force-pushed
the
HBX-2780
branch
23 times, most recently
from
a6f0adb
to
4026cf5
Compare
- Fix build and test problems on CI:
* Initialize 'TypeRegistry#TYPE_REGISTRY' and get rid of the static initialization
* Perform lazy initialization on 'TypeRegistry#TYPE_FORMATS' in method 'TypeRegistry#getTypeFormats()'
* Initialize the default Locale to a fixed one in TypeFactoryWrapperTest and in TypeRegistryTest
Signed-off-by: Koen Aers <koen.aers@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.