HSEARCH-5131 Remove usage and mentions of a security manager

backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/gson/impl/AbstractConfiguredExtraPropertiesJsonAdapterFactory.java

@@ -115,7 +115,7 @@ private static <T> Constructor<T> getConstructor(TypeToken<T> type) {
 		try {
 			return (Constructor<T>) type.getRawType().getConstructor();
 		}
-		catch (NoSuchMethodException | SecurityException e) {
+		catch (NoSuchMethodException e) {
 			throw new AssertionFailure( "Missing or inaccessible no-arg constructor on type " + type );
 		}
 	}

engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ClassLoaderHelper.java

@@ -73,7 +73,7 @@ public static <T> T instanceFromName(Class<T> targetSuperType,
 	 * @return a new instance of classToLoad
 	 *
 	 * @throws SearchException wrapping other error types with a proper error message for all kind of problems, like
-	 * missing proper constructor, securitymanager errors.
+	 * missing proper constructor errors.
 	 */
 	public static <T> T untypedInstanceFromClass(final Class<T> classToLoad) {
 		try {
@@ -142,9 +142,6 @@ private static <T> T callNoArgConstructor(Class<T> classToLoad)
 			Constructor<T> constructor = classToLoad.getConstructor();
 			return constructor.newInstance();
 		}
-		catch (SecurityException e) {
-			throw log.securityManagerLoadingError( classToLoad, e.getMessage(), e );
-		}
 		catch (NoSuchMethodException e) {
 			throw log.noPublicNoArgConstructor( classToLoad );
 		}
@@ -160,9 +157,6 @@ private static <T> T callMapArgConstructor(Class<T> classToLoad, Map<String, Str
 			Constructor<T> singleMapConstructor = classToLoad.getConstructor( Map.class );
 			return singleMapConstructor.newInstance( constructorParameter );
 		}
-		catch (SecurityException e) {
-			throw log.securityManagerLoadingError( classToLoad, e.getMessage(), e );
-		}
 		catch (NoSuchMethodException e) {
 			throw log.noPublicMapArgConstructor( classToLoad );
 		}

engine/src/main/java/org/hibernate/search/engine/environment/thread/impl/EmbeddedThreadProvider.java

@@ -9,7 +9,6 @@
 import java.util.concurrent.ThreadFactory;
 
 import org.hibernate.search.engine.environment.thread.spi.ThreadProvider;
-import org.hibernate.search.util.common.annotation.impl.SuppressForbiddenApis;
 
 public final class EmbeddedThreadProvider implements ThreadProvider {
 
@@ -31,13 +30,8 @@ public String createThreadName(String prefix, int threadNumber) {
 	}
 
 	@Override
-	@SuppressForbiddenApis(reason = "It's unclear how we will handle this without the security manager;"
-			+ " we'll see when the security manager actually gets removed from the JDK")
 	public ThreadFactory createThreadFactory(String prefix) {
-		@SuppressWarnings("removal")
-		SecurityManager s = System.getSecurityManager();
-		@SuppressWarnings({ "removal", "deprecation" })
-		ThreadGroup group = ( s != null ) ? s.getThreadGroup() : Thread.currentThread().getThreadGroup();
+		ThreadGroup group = Thread.currentThread().getThreadGroup();
 		String namePrefix = createFullThreadNamePrefix( prefix );
 		return new SimpleThreadFactory( group, namePrefix );
 	}

engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java

@@ -172,10 +172,6 @@ void newCollectedFailure(String process,
 	)
 	SearchException dslExtensionNoMatch(List<?> attemptedExtensions);
 
-	@Message(id = ID_OFFSET + 28, value = "Security manager does not allow access to the constructor of type '%1$s': %2$s")
-	SearchException securityManagerLoadingError(@FormatWith(ClassFormatter.class) Class<?> classToLoad,
-			String causeMessage, @Cause Exception cause);
-
 	@Message(id = ID_OFFSET + 30, value = "Unable to load class '%1$s': %2$s")
 	ClassLoadingException unableToLoadTheClass(String className, String causeMessage, @Cause Throwable cause);
 

mapper/orm/src/main/java/org/hibernate/search/mapper/orm/model/impl/HibernateOrmBootstrapIntrospector.java

@@ -12,7 +12,6 @@
 import java.lang.reflect.Field;
 import java.lang.reflect.Member;
 import java.lang.reflect.Method;
-import java.lang.reflect.Modifier;
 import java.util.HashMap;
 import java.util.LinkedHashSet;
 import java.util.Map;
@@ -154,17 +153,10 @@ private <T> HibernateOrmClassRawTypeModel<T> createClassTypeModel(Class<T> type)
 	}
 
 	private static void setAccessible(Member member) {
-		try {
-			// always try to set accessible to true regardless of visibility
-			// as it's faster even for public fields:
-			// it bypasses the security model checks at execution time.
-			( (AccessibleObject) member ).setAccessible( true );
-		}
-		catch (SecurityException se) {
-			if ( !Modifier.isPublic( member.getModifiers() ) ) {
-				throw se;
-			}
-		}
+		// always try to set accessible to true regardless of visibility
+		// as it's faster even for public fields:
+		// it bypasses the security model checks at execution time.
+		( (AccessibleObject) member ).setAccessible( true );
 	}
 
 	/**

mapper/pojo-standalone/src/main/java/org/hibernate/search/mapper/pojo/standalone/model/impl/StandalonePojoBootstrapIntrospector.java

@@ -10,7 +10,6 @@
 import java.lang.reflect.AccessibleObject;
 import java.lang.reflect.Constructor;
 import java.lang.reflect.Member;
-import java.lang.reflect.Modifier;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -94,16 +93,9 @@ private <T> PojoRawTypeModel<T> createTypeModel(Class<T> clazz) {
 	}
 
 	private static void setAccessible(Member member) {
-		try {
-			// always try to set accessible to true regardless of visibility
-			// as it's faster even for public fields:
-			// it bypasses the security model checks at execution time.
-			( (AccessibleObject) member ).setAccessible( true );
-		}
-		catch (SecurityException se) {
-			if ( !Modifier.isPublic( member.getModifiers() ) ) {
-				throw se;
-			}
-		}
+		// always try to set accessible to true regardless of visibility
+		// as it's faster even for public fields:
+		// it bypasses the security model checks at execution time.
+		( (AccessibleObject) member ).setAccessible( true );
 	}
 }