New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HSEARCH-4971 Switch project license to Apache License 2.0 #4062
Draft
yrodiere
wants to merge
14
commits into
hibernate:main
Choose a base branch
from
yrodiere:HSEARCH-4971
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-bekhta
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
yrodiere
force-pushed
the
HSEARCH-4971
branch
5 times, most recently
from
March 25, 2024 13:39
01d5a4f
to
dae0b80
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-4971
See https://in.relation.to/2023/11/18/license/
Creating as draft while we're reviewing some final details.
Best reviewed commit by commit, due to the huge, annoying commit that changes file headers (which, obviously, doesn't need reviewing -- there are automated checks for that).
I've gone through past contributions and, unless I am mistaken, we've got permission for this change from all authors of non-trivial contributions that are still present in the repo (some contributions have been deleted in subsequent refactorings, mainly Hibernate Search 6.0).
I've also had to remove a few tests inherited from Search 5, which nowadays are mainly relevant to the v5migrationhelper modules, so... they would probably have been removed in 8.0 along with the v5 migration helpers anyway. Not to detract from those contributions, they were definitely useful (and will continue to be) in v5; it's just that a lot has changed since then, so in newer versions, we can live without them.