Integration with H2 #1336

DavideD · 2022-06-13T18:12:03Z

Fix #929
It's a draft because I need to review it

DavideD · 2022-06-14T12:59:40Z

We had this error on CI (I need to have a look at it later):


Gradle Test Executor 1 > org.hibernate.reactive.CacheTest > testCacheWithNativeSQL FAILED
    java.util.concurrent.CompletionException: javax.persistence.PersistenceException: org.hibernate.HibernateException: java.util.concurrent.CompletionException: java.lang.NullPointerException
        at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314)
        at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319)
        at java.base/java.util.concurrent.CompletableFuture.uniHandle(CompletableFuture.java:932)
        at java.base/java.util.concurrent.CompletableFuture.uniHandleStage(CompletableFuture.java:946)
        at java.base/java.util.concurrent.CompletableFuture.handle(CompletableFuture.java:2266)
        at java.base/java.util.concurrent.CompletableFuture.handle(CompletableFuture.java:143)
        at org.hibernate.reactive.session.impl.ReactiveSessionImpl.firePersist(ReactiveSessionImpl.java:678)
        at org.hibernate.reactive.session.impl.ReactiveSessionImpl.reactivePersist(ReactiveSessionImpl.java:662)
        at org.hibernate.reactive.util.impl.CompletionStages.lambda$loop$2(CompletionStages.java:177)
        at org.hibernate.reactive.util.impl.CompletionStages$ArrayLoop.next(CompletionStages.java:396)
        at org.hibernate.reactive.util.async.impl.AsyncTrampoline.lambda$asyncWhile$1(AsyncTrampoline.java:215)
        at org.hibernate.reactive.util.async.impl.AsyncTrampoline$TrampolineInternal.unroll(AsyncTrampoline.java:121)
        at org.hibernate.reactive.util.async.impl.AsyncTrampoline$TrampolineInternal.trampoline(AsyncTrampoline.java:102)
        at org.hibernate.reactive.util.async.impl.AsyncTrampoline.asyncWhile(AsyncTrampoline.java:197)
        at org.hibernate.reactive.util.async.impl.AsyncTrampoline.asyncWhile(AsyncTrampoline.java:215)
        at org.hibernate.reactive.util.impl.CompletionStages.loop(CompletionStages.java:356)
        at org.hibernate.reactive.util.impl.CompletionStages.loop(CompletionStages.java:340)
        at org.hibernate.reactive.util.impl.CompletionStages.loop(CompletionStages.java:177)
        at org.hibernate.reactive.util.impl.CompletionStages.applyToAll(CompletionStages.java:419)
        at org.hibernate.reactive.stage.impl.StageSessionImpl.persist(StageSessionImpl.java:137)
        at org.hibernate.reactive.CacheTest.lambda$testCacheWithNativeSQL$32(CacheTest.java:135)
        Caused by:
        javax.persistence.PersistenceException: org.hibernate.HibernateException: java.util.concurrent.CompletionException: java.lang.NullPointerException
            at app//org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:154)
            at app//org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:181)
            at app//org.hibernate.reactive.session.impl.ReactiveExceptionConverter.convert(ReactiveExceptionConverter.java:31)
            at app//org.hibernate.reactive.session.impl.ReactiveSessionImpl.lambda$firePersist$18(ReactiveSessionImpl.java:685)
            at java.base@11.0.15/java.util.concurrent.CompletableFuture.uniHandle(CompletableFuture.java:930)
            ... 18 more
            Caused by:
            org.hibernate.HibernateException: java.util.concurrent.CompletionException: java.lang.NullPointerException
                at app//org.hibernate.reactive.session.impl.ReactiveExceptionConverter.convert(ReactiveExceptionConverter.java:31)
                ... 20 more
                Caused by:
                java.util.concurrent.CompletionException: java.lang.NullPointerException
                    at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314)
                    at java.base/java.util.concurrent.CompletableFuture.uniApplyNow(CompletableFuture.java:683)
                    at java.base/java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:658)
                    at java.base/java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:2094)
                    at java.base/java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:143)
                    at org.hibernate.reactive.id.impl.SequenceReactiveIdentifierGenerator.nextHiValue(SequenceReactiveIdentifierGenerator.java:45)
                    at org.hibernate.reactive.id.impl.BlockingIdentifierGenerator.generate(BlockingIdentifierGenerator.java:59)
                    at org.hibernate.reactive.id.impl.ReactiveGeneratorWrapper.generate(ReactiveGeneratorWrapper.java:38)
                    at org.hibernate.reactive.id.impl.IdentifierGeneration.generateId(IdentifierGeneration.java:140)
                    at org.hibernate.reactive.event.impl.AbstractReactiveSaveEventListener.reactiveSaveWithGeneratedId(AbstractReactiveSaveEventListener.java:122)
                    at org.hibernate.reactive.event.impl.DefaultReactivePersistEventListener.entityIsTransient(DefaultReactivePersistEventListener.java:179)
                    at org.hibernate.reactive.event.impl.DefaultReactivePersistEventListener.reactiveOnPersist(DefaultReactivePersistEventListener.java:128)
                    at org.hibernate.reactive.event.impl.DefaultReactivePersistEventListener.reactiveOnPersist(DefaultReactivePersistEventListener.java:58)
                    at org.hibernate.event.service.internal.EventListenerGroupImpl.lambda$fireEventOnEachListener$0(EventListenerGroupImpl.java:133)
                    at java.base/java.util.concurrent.CompletableFuture.uniComposeStage(CompletableFuture.java:1106)
                    at java.base/java.util.concurrent.CompletableFuture.thenCompose(CompletableFuture.java:2235)
                    at java.base/java.util.concurrent.CompletableFuture.thenCompose(CompletableFuture.java:143)
                    at org.hibernate.event.service.internal.EventListenerGroupImpl.fireEventOnEachListener(EventListenerGroupImpl.java:133)
                    at org.hibernate.reactive.session.impl.ReactiveSessionImpl.firePersist(ReactiveSessionImpl.java:676)
                    ... 14 more
                    Caused by:
                    java.lang.NullPointerException
                        at java.base/java.util.concurrent.CompletableFuture.uniApplyNow(CompletableFuture.java:680)

MySQL always returns an id of type Long. This commit changes an hack that was affecting all dbs and preventing H2 to read identity id of type Integer or Short

Sanne · 2022-06-22T21:04:11Z

hibernate-reactive-core/src/test/java/org/hibernate/reactive/containers/H2Database.java

+
+	@Override
+	public String getUri() {
+		return "h2:~/test;DATABASE_TO_UPPER=FALSE;DB_CLOSE_DELAY=-1";


This will use an H2 instance baked by a file in the home directory. Could we use an in-memory instance instead?

Thanks, I will change it

DavideD force-pushed the wip/h2 branch 2 times, most recently from ae5a255 to 7b4f29a Compare June 14, 2022 12:40

DavideD mentioned this pull request Jun 14, 2022

Add support for H2 #929

Open

DavideD force-pushed the wip/h2 branch from 7b4f29a to cb8c33c Compare June 14, 2022 22:21

DavideD and others added 8 commits June 22, 2022 16:12

[hibernate#929] Refactor id generation for MySQL

bff1835

MySQL always returns an id of type Long. This commit changes an hack that was affecting all dbs and preventing H2 to read identity id of type Integer or Short

[hibernate#929] hibernate-reactive-h2 module

0a4946e

[hibernate#929] H2

4888ea2

[hibernate#929] Add H2Database

4794c78

[hibernate#929] Adapt or disable existing tests for H2

13dbccc

[hibernate#929] Add H2 to the GitHub workflows

6ebda19

Add ;DB_CLOSE_DELAY=-1 to testing url

6c3a488

Remove unused import

31e554f

DavideD force-pushed the wip/h2 branch from b8a67e7 to 31e554f Compare June 22, 2022 15:13

Sanne reviewed Jun 22, 2022

View reviewed changes

Use H2 in memory as default

9bee7be

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integration with H2 #1336

Integration with H2 #1336

DavideD commented Jun 13, 2022 •

edited

DavideD commented Jun 14, 2022 •

edited

Sanne Jun 22, 2022

DavideD Jun 22, 2022

Integration with H2 #1336

Are you sure you want to change the base?

Integration with H2 #1336

Conversation

DavideD commented Jun 13, 2022 • edited

DavideD commented Jun 14, 2022 • edited

Sanne Jun 22, 2022

Choose a reason for hiding this comment

DavideD Jun 22, 2022

Choose a reason for hiding this comment

DavideD commented Jun 13, 2022 •

edited

DavideD commented Jun 14, 2022 •

edited