Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-18020 Align behavior of ClobJdbcType with BlobJdbcType #8260

Merged
merged 3 commits into from May 2, 2024

Conversation

gavinking
Copy link
Member

@gavinking gavinking commented Apr 27, 2024

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Apr 27, 2024

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [c51b116, 4aa8bd3]

› This message was automatically generated.

@gavinking gavinking marked this pull request as draft April 27, 2024 12:51
@gavinking gavinking force-pushed the clob-to-string branch 2 times, most recently from 937d048 to 74f08f8 Compare April 27, 2024 14:57
@gavinking gavinking changed the title Align behavior of ClobJdbcType with BlobJdbcType HHH-18020 Align behavior of ClobJdbcType with BlobJdbcType Apr 27, 2024
@gavinking gavinking force-pushed the clob-to-string branch 3 times, most recently from a4a00a2 to 055cf1e Compare April 29, 2024 11:38
@sebersole
Copy link
Member

Looks good to me. Please squash the commits though

@beikov
Copy link
Contributor

beikov commented Apr 30, 2024

We should IMO discuss this on Thursday, since there seem to be some inconsistencies with how this useStreams flag is interpreted.

@gavinking
Copy link
Member Author

there seem to be some inconsistencies with how this useStreams flag is interpreted

I think I cleaned that up in the last commit, no?

@gavinking gavinking marked this pull request as ready for review May 2, 2024 17:31
Signed-off-by: Gavin King <gavin@hibernate.org>
Signed-off-by: Gavin King <gavin@hibernate.org>
@gavinking gavinking merged commit d0ed4d0 into hibernate:main May 2, 2024
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants