New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-17960: Fix proper default session type for JD repositories even in Quarkus #8199
Conversation
The error in CI is:
I'm frankly not sure why this happens, apparently 55 is Java 11, and 61 is Java 17. But that JD dep is also used from the jpamodelgen tests, so I'm not sure why it works there and not here. @gavinking any idea? |
We are not currently running the JD tests on the CI, I'm just running them by hand. |
Oh, damn. |
I guess it would be nice to set up a CI job for these things which require newer Javas. |
So… I suppose the best thing to do is to disable those tests in this PR? |
Well, we could tie them to the |
That seems like a good idea. Let me try. |
…n Quarkus And tests
4bd2ea8
to
f156327
Compare
@gavinking there's a pipeline job stuck, but otherwise, test seems to pass. Any chance you can review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks. |
I've no idea about the CI issues, can we get this merged? |
@FroMage I already approved it |
Approuved, but wasn't merged :) Thanks! |
And tests
As discussed at https://hibernate.atlassian.net/browse/HHH-17960