Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-17960: Fix proper default session type for JD repositories even in Quarkus #8199

Merged
merged 1 commit into from May 14, 2024

Conversation

FroMage
Copy link
Contributor

@FroMage FroMage commented Apr 18, 2024

@FroMage
Copy link
Contributor Author

FroMage commented Apr 19, 2024

The error in CI is:

java.lang.AssertionError: There was a compilation error during annotation processing:
/home/runner/work/hibernate-orm/hibernate-orm/tooling/metamodel-generator/target/classes/processor-generated-test-classes/org/hibernate/processor/test/hrPanache/_PanacheBook.java:6: error: cannot access jakarta.data.metamodel.SortableAttribute
import jakarta.data.metamodel.SortableAttribute;
                             ^
  bad class file: /home/runner/.gradle/caches/modules-2/files-2.1/jakarta.data/jakarta.data-api/1.0.0-SNAPSHOT/cca3668e18597f5e1c8544c68ef0dccc470bae33/jakarta.data-api-1.0.0-SNAPSHOT.jar(/jakarta/data/metamodel/SortableAttribute.class)
    class file has wrong version 61.0, should be 55.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.

I'm frankly not sure why this happens, apparently 55 is Java 11, and 61 is Java 17. But that JD dep is also used from the jpamodelgen tests, so I'm not sure why it works there and not here.

@gavinking any idea?

@gavinking
Copy link
Member

We are not currently running the JD tests on the CI, I'm just running them by hand.

@FroMage
Copy link
Contributor Author

FroMage commented Apr 19, 2024

Oh, damn.

@gavinking
Copy link
Member

I guess it would be nice to set up a CI job for these things which require newer Javas.

@FroMage
Copy link
Contributor Author

FroMage commented Apr 19, 2024

So… I suppose the best thing to do is to disable those tests in this PR?

@gavinking
Copy link
Member

Well, we could tie them to the jakartaDataTest task, and run them manually.

@FroMage
Copy link
Contributor Author

FroMage commented May 3, 2024

Well, we could tie them to the jakartaDataTest task, and run them manually.

That seems like a good idea. Let me try.

@FroMage
Copy link
Contributor Author

FroMage commented May 6, 2024

@gavinking there's a pipeline job stuck, but otherwise, test seems to pass.

Any chance you can review?

Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FroMage
Copy link
Contributor Author

FroMage commented May 6, 2024

Thanks.

@FroMage
Copy link
Contributor Author

FroMage commented May 14, 2024

I've no idea about the CI issues, can we get this merged?

@gavinking
Copy link
Member

@FroMage I already approved it

@gavinking gavinking merged commit 1948c8f into hibernate:main May 14, 2024
20 of 23 checks passed
@FroMage
Copy link
Contributor Author

FroMage commented May 14, 2024

Approuved, but wasn't merged :) Thanks!

@FroMage FroMage deleted the processor-fixes-quarkus branch May 14, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants