enhance type-checked result effect during the call to createQuery() #8152

FULaBUla · 2024-04-11T15:27:53Z

I have provided an implementation for HH-17926, please check it out.

https://hibernate.atlassian.net/browse/HHH-17926

…eQuery()

gavinking · 2024-04-11T15:52:35Z

hibernate-core/src/main/java/org/hibernate/query/hql/internal/SemanticQueryBuilder.java

 			if ( dynamicInstantiation.isFullyAliased() ) {
-				throw new SemanticException( "Missing constructor or attributes for injection into type '" + typeName + "'", query );
+				throw new SemanticException("Missing constructor or attributes for injection into type [" + type + "]." +


Please back out this change and the other one like it.

we don't need punctuation at the end of exception messages, that's quite nonstandard, and

I have been gradually migrating to the use of single quotes for quoting the names of program elements, since square brackets have more visual weight than is needed for this purpose.

Thanks for reminding me, I have finished the modification

hibernate-github-bot · 2024-04-12T12:33:14Z

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

# change 1. remove punctuation at the end of exception messages 2. replace square brackets with single quotes

gavinking · 2024-04-12T12:49:12Z

hibernate-core/src/main/java/org/hibernate/query/hql/internal/SemanticQueryBuilder.java

 			if ( dynamicInstantiation.isFullyAliased() ) {
-				throw new SemanticException( "Missing constructor or attributes for injection into type '" + typeName + "'", query );
+				throw new SemanticException("Missing constructor or attributes for injection into type '" + type + "'" +


Suggested change

throw new SemanticException("Missing constructor or attributes for injection into type '" + type + "'" +

throw new SemanticException("Missing constructor or attributes for injection into type '" + type.getSimpleName() + "'" +

I think a type description like com.excemple.A would be clearer than just
showing A, especially if there are classes with duplicate names, and
would make it easier to find problematic classes more quickly.

I'm not certain I agree, but anyway that's not what you have there. You are calling Class.toString(), which does not just return the qualified name.

I understand your concern, I've used Class.getName() replace Class.toString().

# change 1. using Class.getName() replace Class.toString()

gavinking · 2024-04-18T14:28:39Z

hibernate-core/src/main/java/org/hibernate/query/hql/internal/SemanticQueryBuilder.java

+									.map(InstantiationHelper.MismatchConstructorFieldPositionInfo::toString)
+									.collect(Collectors.joining(","));


You can use StringHelper.join() for this.

I have finished the modification

gavinking · 2024-04-18T14:29:10Z

hibernate-core/src/main/java/org/hibernate/query/hql/internal/SemanticQueryBuilder.java

+				List<InstantiationHelper.MismatchConstructorFieldPositionInfo> list = dynamicInstantiation.findMismatchConstructorFieldPositions(creationContext.getTypeConfiguration());
+
+				String conjecture = "";
+				if (list != null && list.isEmpty() == false) {


Suggested change

if (list != null && list.isEmpty() == false) {

if ( list != null && !list.isEmpty() ) {

I have finished the modification

gavinking · 2024-04-18T14:33:11Z

hibernate-core/src/main/java/org/hibernate/query/hql/internal/SemanticQueryBuilder.java

+				throw new SemanticException("Unable to locate appropriate constructor on class '" + qualifiedName + "'. " +
+						"Expected arguments are: " + dynamicInstantiation.argumentTypes() + conjecture, query);


Suggested change

throw new SemanticException("Unable to locate appropriate constructor on class '" + qualifiedName + "'. " +

"Expected arguments are: " + dynamicInstantiation.argumentTypes() + conjecture, query);

throw new SemanticException( "Missing constructor for class '" + qualifiedName + "' with parameter types ["

+ dynamicInstantiation.argumentTypes() + "] (" + conjecture + ")", query );

I have finished the modification

gavinking · 2024-04-18T14:34:32Z

hibernate-core/src/main/java/org/hibernate/query/hql/internal/SemanticQueryBuilder.java

+
+				String conjecture = "";
+				if (list != null && list.isEmpty() == false) {
+					conjecture = " The presumed mismatch field position is: " +


Suggested change

conjecture = " The presumed mismatch field position is: " +

conjecture = "mismatch at position " +

I have finished the modification

gavinking · 2024-04-18T14:47:19Z

hibernate-core/src/main/java/org/hibernate/query/hql/internal/SemanticQueryBuilder.java

+				throw new SemanticException("Missing constructor or attributes for injection into type '" + qualifiedName + "'" +
+						"Expected arguments are: " + dynamicInstantiation.argumentTypes(), query);


Suggested change

throw new SemanticException("Missing constructor or attributes for injection into type '" + qualifiedName + "'" +

"Expected arguments are: " + dynamicInstantiation.argumentTypes(), query);

throw new SemanticException( "Missing constructor or attributes for injection into class '" + qualifiedName + "'" +

" of selected types [" + dynamicInstantiation.argumentTypes() + "]", query );

I have finished the modification

# change 1. modify code format 2. modify the format of exception information

# change 1. use StringHelper.join() instead of stream processing

FULaBUla · 2024-04-24T15:47:03Z

Is there anything I would like to change about this branch? @gavinking

HHH-17926 enhance type-checked result effect during the call to creat…

71f1276

…eQuery()

FULaBUla changed the title ~~HHH-17926 enhance type-checked result effect during the call to createQuery()~~ enhance type-checked result effect during the call to createQuery() Apr 11, 2024

gavinking reviewed Apr 11, 2024

View reviewed changes

HHH-17926 Refactor: change exception message

1f8af8c

# change 1. remove punctuation at the end of exception messages 2. replace square brackets with single quotes

FULaBUla force-pushed the HHH-17926 branch from 38ba710 to 1f8af8c Compare April 12, 2024 12:35

gavinking reviewed Apr 12, 2024

View reviewed changes

HHH-17926 Refactor: using qualified name

0b8574b

# change 1. using Class.getName() replace Class.toString()

FULaBUla force-pushed the HHH-17926 branch from 9231611 to 0b8574b Compare April 13, 2024 16:32

FULaBUla requested a review from gavinking April 18, 2024 14:07

gavinking reviewed Apr 18, 2024

View reviewed changes

FULaBUla added 2 commits April 18, 2024 22:55

HHH-17926 Refactor: formatted code

3f36dff

# change 1. modify code format 2. modify the format of exception information

HHH-17926 Refactor: instead of stream processing

d14dcdf

# change 1. use StringHelper.join() instead of stream processing

FULaBUla force-pushed the HHH-17926 branch from ef71f0b to d14dcdf Compare April 18, 2024 14:55

FULaBUla requested a review from gavinking April 18, 2024 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enhance type-checked result effect during the call to createQuery() #8152

enhance type-checked result effect during the call to createQuery() #8152

FULaBUla commented Apr 11, 2024 •

edited by hibernate-github-bot bot

gavinking Apr 11, 2024

FULaBUla Apr 12, 2024

hibernate-github-bot bot commented Apr 12, 2024 •

edited

gavinking Apr 12, 2024

FULaBUla Apr 13, 2024

gavinking Apr 13, 2024 •

edited

FULaBUla Apr 13, 2024 •

edited

gavinking Apr 18, 2024

FULaBUla Apr 18, 2024

gavinking Apr 18, 2024

FULaBUla Apr 18, 2024

gavinking Apr 18, 2024 •

edited

FULaBUla Apr 18, 2024

gavinking Apr 18, 2024 •

edited

FULaBUla Apr 18, 2024

gavinking Apr 18, 2024 •

edited

FULaBUla Apr 18, 2024

FULaBUla commented Apr 24, 2024

	throw new SemanticException("Missing constructor or attributes for injection into type '" + type + "'" +
	throw new SemanticException("Missing constructor or attributes for injection into type '" + type.getSimpleName() + "'" +

		.map(InstantiationHelper.MismatchConstructorFieldPositionInfo::toString)
		.collect(Collectors.joining(","));

	if (list != null && list.isEmpty() == false) {
	if ( list != null && !list.isEmpty() ) {

		throw new SemanticException("Unable to locate appropriate constructor on class '" + qualifiedName + "'. " +
		"Expected arguments are: " + dynamicInstantiation.argumentTypes() + conjecture, query);

	conjecture = " The presumed mismatch field position is: " +
	conjecture = "mismatch at position " +

enhance type-checked result effect during the call to createQuery() #8152

Are you sure you want to change the base?

enhance type-checked result effect during the call to createQuery() #8152

Conversation

FULaBUla commented Apr 11, 2024 • edited by hibernate-github-bot bot

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hibernate-github-bot bot commented Apr 12, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavinking Apr 13, 2024 • edited

Choose a reason for hiding this comment

FULaBUla Apr 13, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavinking Apr 18, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavinking Apr 18, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavinking Apr 18, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FULaBUla commented Apr 24, 2024

FULaBUla commented Apr 11, 2024 •

edited by hibernate-github-bot bot

hibernate-github-bot bot commented Apr 12, 2024 •

edited

gavinking Apr 13, 2024 •

edited

FULaBUla Apr 13, 2024 •

edited

gavinking Apr 18, 2024 •

edited

gavinking Apr 18, 2024 •

edited

gavinking Apr 18, 2024 •

edited