HHH-15752 Add Boolean support to oracle dialect

[ejannett]

Hi,

This pull request is about adding Boolean support to Oracle dialect.
Starting to version 23 the new BOOLEAN type will be used for Boolean entity fields.

Local tests have been run successfully.

Important note: This PR should be put on hold until further notice as it requires an external change.

https://hibernate.atlassian.net/browse/HHH-15752
https://hibernate.atlassian.net/browse/HHH-18123

[beikov]

Looks good. Please fixup some code style problems and then I'll run tests.

[hibernate-github-bot]

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

[beikov]

And please squash the commits to a single one :)

[ejannett]

Note that test failures on Java11/oracle_db23c are due to external changes that PR depend on.

[beikov]

What is this external change if I may ask?

[ejannett]

What is this external change if I may ask?

Hi,
There is a fix required in the driver to properly inserted right values in Boolean array

[ejannett]

@beikov I see errors related to pool starvation in java11//oracle_atps . Is there an environment issue right now in the tests?

[beikov]

@beikov I see errors related to pool starvation in java11//oracle_atps . Is there an environment issue right now in the tests?

I just rebased to run the tests again. @loiclefevre fixed a problem in the ATPS environment yesterday.

[beikov]

Is the driver fix released yet i.e. can we continue with this PR?

[ejannett]

Is the driver fix released yet i.e. can we continue with this PR?

Hi,
The needed fix will be release by next driver release.
We gonna continue with this PR then.

Thank you for your comprehension

[beikov]

Please rebase the PR.

[beikov]

Rebase please. We don't want merge commits.

[ejannett]

Hi @beikov it seems that the workflow is stuck.

[beikov]

There is a compile error and apparently also a conflict after your merge commit. Please fix that, then I'll re-run the workflow.

[loiclefevre]

@ejannett, @beikov I think the JDBC driver has to be upgraded as well...

[loiclefevre]

@ejannett, @beikov I think the JDBC driver has to be upgraded as well...

I see def oracleVersion = version "oracle", "23.3.0.23.09" inside settings.gradle instead of def oracleVersion = version "oracle", "23.4.0.24.05"

[loiclefevre]

Also UCP version should be bumped too.

[ejannett]

@beikov Shall I update the version of the driver or is this be part of another PR?

[beikov]

Yes, please update as part of the PR.

[beikov]

Please also add dialect skips for StructWithArrayEmbeddableTest#testSelectionItems, BooleanArrayTest#testNativeQueryUntyped and JsonWithArrayEmbeddableTest#testUpdateAllAggregateMembers, since these tests are also affected by the boolean array JDBC driver bug.

[beikov]

Thanks!