Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sameSite attribute in response sendCookies() #372

Open
wants to merge 1 commit into
base: PHP-7.x
Choose a base branch
from
Open

Added sameSite attribute in response sendCookies() #372

wants to merge 1 commit into from

Conversation

IvanII
Copy link

@IvanII IvanII commented Sep 8, 2021

fix for issue #371

@hhxsv5
Copy link
Owner

hhxsv5 commented Sep 9, 2021 •
edited

Nice, but you have to consider backward compatibility.
Swoole cookie(..., $samesite) requires Swoole>= 4.4.6.
Cookie::getSameSite() requires symfony/http-foundation >= 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IvanII @hhxsv5