Added config to force scheme for the server request. #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm looking forward to hear others opinion in this subject. While trying to set up a Swoole server along, without any proxy, I faced the challenge of not being able to properly make sure that all the routes in the application had the same scheme (HTTPS). After some investigation I noticed that what was failing was the fact that Swoole (I'm using 4.6.6, but I tested since 4.5.*) is not adding to the request the 'scheme'.
I wonder if this is a problem on my local, but after many different combinations, php8.0-cli, php7.4-cli, laravel 8, bare metal, dockerized, I get the same always.
That said, I added this fix, that worked for all the tests that I did, and for all the helpers and routes generators through laravel.
IF this is something thet others are also experiencing, it might be helpful.