Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use application reg in docs #1931

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

andrewgsavage
Copy link
Collaborator

@andrewgsavage andrewgsavage commented Feb 2, 2024

  • Closes Plotting with Matplotlib from Pandas #1917
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

replaces ureg = pint.UnitRegistry() with ureg = pint.get_application_registry() in the docs

Copy link

codspeed-hq bot commented Feb 2, 2024

CodSpeed Performance Report

Merging #1931 will degrade performances by 20.71%

Comparing andrewgsavage:app_reg (32f0bac) with master (3cc2d36)

Summary

❌ 1 regressions
✅ 438 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master andrewgsavage:app_reg Change
test_create_empty_registry 2.3 ms 2.9 ms -20.71%

@andrewgsavage
Copy link
Collaborator Author

Some small changes to the text in docs/getting/tutorial.rst
I think using pint in your projects needs a bit of a rewrite to recommend using set_application_registry

@hgrecco
Copy link
Owner

hgrecco commented Mar 11, 2024

As I mentiones before, I like this change. I was discussing this with some friends which are not pint users. A lot of them ask "why get_application_registry?, Why so long?, Do you really need the application part of the name?"

Shall we bikeshed this public API? (we can still leave get_application_registry to avoid breaking things but maybe there is a better name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotting with Matplotlib from Pandas
2 participants