New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nft mint open action #4679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
12 tasks
Screen.Recording.2024-05-14.at.7.52.21.PM.movStill on clicking outside takes to the post page |
Screen.Recording.2024-05-14.at.7.54.16.PM.movSeeing CLS issue, I can't continuously click on plus because the layout got shifted also it showing wrong message on shimmer while clicking plus |
Do i need to approve everytime before collecting? Aka for collecting need to do 3 signs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR integrates the Decent.xyz cross-chain open action module and NFT open action library to automatically attach an open action module to publications containing URLs for supported NFT collections, and allow these NFTs to be minted/purchased directly within the social feed through cross-chain transactions.
Automatically attach cross-chain NFT open action to Publications with supported NFT links:
detectAndReturnCalldata
function from NFT Open Action libraryIf Publication appears in feed with cross-chain NFT open action module:
actionDataFromPost
function in NFT Open Action Library tofetch action calldata from Decent API for bridge + exchange routing and platform context (types shown below)
Testing
Action is only configured to work on Polygon mainnet (due to inconsistencies with testnet NFT contracts and Amoy bridging).
Examples from supported collections to test embedding and executing the action are listed below:
Related issues
HEY-7
Type of change
Explanation of the changes
This PR replaces the existing NFT embed displays. Instead of linking to an external site, it will allow minting Zora NFTs (and other supported collections) directly within the feed.