Skip to content
This repository has been archived by the owner on Aug 21, 2019. It is now read-only.

Better to work friendly on mobile device #6

Open
OrNot opened this issue Jul 15, 2016 · 5 comments
Open

Better to work friendly on mobile device #6

OrNot opened this issue Jul 15, 2016 · 5 comments

Comments

@OrNot
Copy link

OrNot commented Jul 15, 2016

Is there any way to achieve the goal to have bigger buttons and easy to click on mobile browser ?

Thanks a lot

@hexylena
Copy link
Owner

Hi @OrNot, I'm afraid I do not know. I tried this on my phone after reading this issue and found the buttons completely unclickable, not good! Unfortunately I am not very familiar with videojs/mobile browsers, and we do not primarily target mobile, so I'm afraid I won't find time for solving this any time soon. :(

If anyone finds this issue and develops a patch, they would be extremely welcome.

@OrNot
Copy link
Author

OrNot commented Jul 15, 2016

OMG...Don't leave me alone please...

Sent from Yahoo Mail on Android

On Fri, Jul 15, 2016 at 18:38, Eric Raschenotifications@github.com wrote:
Hi @OrNot, I'm afraid I do not know. I tried this on my phone after reading this issue and found the buttons completely unclickable, not good! Unfortunately I am not very familiar with videojs/mobile browsers, and we do not primarily target mobile, so I'm afraid I won't find time for solving this any time soon. :(

If anyone finds this issue and develops a patch, they would be extremely welcome.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@fjdiazt
Copy link

fjdiazt commented Jun 20, 2017

I've created a pull request to solve this issue.

@ejalbos
Copy link

ejalbos commented May 4, 2019

Ran into this issue. Had to hand patch since the pull hadn't been addressed. Can verify that it now behaves as I expect on touchscreens.

@ejalbos
Copy link

ejalbos commented May 13, 2019

Regarding the question of the bigger buttons, the frame-by-frame DIVs seem to have inline styling that prevents inheriting from the control bar if you make it bigger font.

I handled this in a custom install wherein I simply changed this line
innerHTML: '<div class="vjs-control-content" style="font-size: 11px; line-height: 28px;"><span class="vjs-fbf">' + opt.text + '</span></div>'
to
innerHTML: '<div class="vjs-control-content"><span class="vjs-fbf">' + opt.text + '</span></div>'

and it still looks fine, inheriting size styling from the control bar. From there, I can problematically change the control bar font-size on mobile devices (not sensed - I have the user explicitly say) and all the buttons on it get bigger.

Not sure if it's the right way, but it works (for me, at least).

Hope that helps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants