click event is fired two times

[dvyskoc]

Check line 11 - this.on('click', this.onClick);
It is redundant. onClick function will run even without it. Currently click event is fired two times when button is clicked.

[hexylena]

nice catch, thanks @DanielVyskoc. should be fixed now.

[Cylix]

Hi,

Without this line, buttons are not clickable and your plugin is not usable.
I'm on google-chrome 43 with videoJS 4.11 (I've also tried on 4.12 4.12.9).

[hexylena]

Hi @Cylix, thanks for spotting this. You're absolutely correct... I should've tested that more extensively. I've already pushed the fix of re-adding this line, and I'll push some more updates today. Thanks again!

[dvyskoc]

Hi, I was using video.dev.js (probably by mistake) back then. With "normal" minimalised version it is working as it should. I am not sure why it is working differently with dev version, but you can try it too. It is same with dev 4.12.7, executing onClick two times.

[hexylena]

... oh, great. More complicated than I thought. I'll try out both and see
what I can do, maybe it's upstream's fault.

Thanks for these comments, y'all.
20. jun. 2015 20.16 skrev "Daniel Vyskoč" notifications@github.com:

Hi, I was using video.dev.js (probably by mistake) back then. With
"normal" minimalised version it is working as it should. I am not sure why
it is working differently with dev version, but you can try it too. It is
same with dev 4.12.7, executing onClick two times.

—
Reply to this email directly or view it on GitHub
#1 (comment)
.

[fjdiazt]

This is related to #6 and #7, the correct way to handle clicks is not calling onClick, but using the handleClick method, like so

var FBFButton = videojs.extend(VjsButton, {
    constructor: function(player, options) {
        VjsButton.call(this, player, options);
        this.player = player;
        this.frameTime = 1/options.fps;
        this.step_size = options.value;
    },

    handleClick:function() {
        // Start by pausing the player
        this.player.pause();
        // Calculate movement distance
        var dist = this.frameTime * this.step_size;
        this.player.currentTime(this.player.currentTime() + dist);
    }
});