Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM builds #174

Merged
merged 5 commits into from
May 15, 2024
Merged

Add ARM builds #174

merged 5 commits into from
May 15, 2024

Conversation

pandadefi
Copy link
Contributor

Building on the already started changes from #152 I have taken into consideration the comments you have made @ericmj please have a look and tell me how to further continue.

@ericmj ericmj force-pushed the main branch 3 times, most recently from 3a7bf17 to bc0c95a Compare April 1, 2024 10:26
Copy link
Member

@ericmj ericmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this PR. It looks good other than some minor changes.

I will take this and do some testing. If any major changes are needed I will let you know.

lib/bob/job/build_otp.ex Outdated Show resolved Hide resolved
lib/bob/job/otp_checker.ex Outdated Show resolved Hide resolved
priv/scripts/otp/otp.sh Outdated Show resolved Hide resolved
priv/scripts/otp/otp.sh Outdated Show resolved Hide resolved
priv/scripts/otp/otp.sh Outdated Show resolved Hide resolved
priv/scripts/otp/otp.sh Outdated Show resolved Hide resolved
priv/scripts/otp/otp.sh Outdated Show resolved Hide resolved
@ericmj ericmj mentioned this pull request May 14, 2024
@pandadefi
Copy link
Contributor Author

Great

@ericmj
Copy link
Member

ericmj commented May 15, 2024

Huge thanks @acco and @pandadefi!

@ericmj ericmj merged commit 93d5c10 into hexpm:main May 15, 2024
5 checks passed
@ericmj
Copy link
Member

ericmj commented May 15, 2024

The builds have started to run, will probably take about a day to run through all the builds for ubuntu-20.04, ubuntu-22.04, and ubuntu-24.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants