Skip to content
This repository has been archived by the owner on Feb 10, 2024. It is now read-only.

Fix issue #1587 (IO Related Freezing during XDCC receive/move) #2127

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix issue #1587 (IO Related Freezing during XDCC receive/move) #2127

wants to merge 5 commits into from

Conversation

bergerspencer
Copy link

@bergerspencer bergerspencer commented Mar 3, 2018 •
edited

Finally remembered/got around to taking a look at this. This is a patch to fix #1587 as described by Arnavion: #1587 (comment). It works for me and prevents freezing in the situations I described in the report.
Questions for review:

  • Is the error handling and error message implementation for the async copy okay?
  • Is it necessary or a good idea to remove the loop in the dcc_read_ack function as well?

@TingPing TingPing requested review from Arnavion and removed request for Arnavion March 3, 2018 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IO Related Freezing during XDCC receive
1 participant
@bergerspencer