Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Proxmox Mail Gateway #4365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0pc0deFR
Copy link
Contributor

I would like to propose this PR to add support for Proxmox Mail Gateway.

In my context, I use a PMG cluster which protects the messaging of my Hestia users.

To avoid being an open relay, PMG requires declaring all domains authorized to use it.

This PR allows you to activate and configure the necessary information on the server configuration page and allows you to automatically add/delete a domain in PMG when an email domain is added in Hestia.

Hestia Settings
image

PMG Relay Domains
image

PMG Transports
image

@jaapmarcus
Copy link
Member

jaapmarcus commented Apr 12, 2024

I am not a real fan to include an another 7 extra options for just one use case. There are multiple other services that require the same but slightly different.

Maybe we we should just add an hook to v-add-mail-domain / v-delete-mail-domain that can handle all the cases so users can create their own implementation they are using?

Like we do on updating package or updating template?

hestiacp/func/rebuild.sh

Lines 68 to 71 in 07f0ac2

# Run template trigger
if [ -x "$HESTIA/data/packages/$PACKAGE.sh" ]; then
$HESTIA/data/packages/$PACKAGE.sh "$user" "$CONTACT" "$NAME"
fi

@johnnyq
Copy link

johnnyq commented Apr 12, 2024

I use Proxmox Mail Gateway for many on prem exchange platforms never thought about using it with HestiaCP
This is pretty awesome but I agree with @jaapmarcus it should absolutely be a hook and not included in the core functions

@Anuril
Copy link
Contributor

Anuril commented Apr 16, 2024

I also like this Idea, but wouldn't that be a perfect fit for a plugin @jaapmarcus ? Like #4361

@coriaweb
Copy link

coriaweb commented May 9, 2024

I like this, I also use Proxmox and I'm doing it manually.

I will try it. I assume that when updating Hestia, all changes are lost, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants