Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Depend on ruby virtual package #1860

Open
wants to merge 1,214 commits into
base: master
Choose a base branch
from
Open

Depend on ruby virtual package #1860

wants to merge 1,214 commits into from

Conversation

adipascu
Copy link
Contributor

This will fix the current issue on debian and
future proof the dependency.
libssl and libreadline are required by ruby.

dickeyxxx and others added 30 commits August 4, 2015 21:44
…ormance-dynos"

This reverts commit ec73163, reversing
changes made to fd8ad8f.
…ename-patch

Revert "Merge pull request heroku#1682 from heroku/omarkj-rename-performanc…
remove foreman and fix el capitan
now that foreman is gone, a directory was missing
ensure that /usr/local/bin exists before creating the symlink there
This changes `heroku apps --space` to use the updated v2 org apps endpoint that now includes the space attribute. Unjoined apps in spaces are now displayed and the rest of the space query and display logic falls inline with orgs now. This also has the side benefit of validating space visibility to improve error messages for unauthorized access.
ensure that HEROKU_HEADERS are used for pg:backups commands
This changes the org app list to always display joined and unjoined apps together in one list for parity with Dashboard. Hiding and segregating unjoined apps has proved to confuse users.

This leaves the --all option in place, but updates the documentation to reflect what is actually does for the personal app list.
Fix `heroku apps --space` to display unjoined apps
master: Always display unjoined org apps
added arrows
added request POST body output
Ransom Briggs and others added 25 commits November 20, 2015 16:41
Add plugins:command to track progress
Platform api requests that don't specify a version will default to v2.
We want requests that return information about spaces or org apps to go
to v3 instead
spaces: don't use platform api dogwood variant
* fixes unicode problems on windows
Remove readline dep & unused protected methods
Change exec(args) to exec(shelljoin(string))
such as whether or not the plugin is symlinked
The underlying problem is that ENV variables with cryllic
characters come in as ASCII-8BIT rather than utf-8

* https://bugs.ruby-lang.org/issues/9715
Be more descriptive about uninstalling Accounts
Fix Windows cryllic character from ENV issues
Revert exec to shellescape while I fix windows bug
Use system & exit on windows when non-ascii args
This will fix the current issue on debian and
future proof the dependency.
libssl and libreadline are required by ruby.
@jdx
Copy link
Contributor

jdx commented Dec 21, 2015

what issue does this fix exactly? I'm also not sure it will work for older ubuntu versions.

@adipascu
Copy link
Contributor Author

The issue is is a broken dependency in debian/testing. Debian currently lacks ruby 2.1 in favor of ruby 2.2

Instead of depending on a specific version i'd rather use the virtual package to prevent future dependency issues.

The ruby virtual package exists in all currently supported versions of ubuntu and debian, it also pulls in a ssl lib and the readline lib.

http://packages.ubuntu.com/search?keywords=ruby

https://packages.debian.org/search?keywords=ruby

@isms
Copy link

isms commented Dec 22, 2015

@dickeyxxx Can confirm issue on Debian stretch:

$ sudo apt-get install heroku
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 heroku : Depends: ruby2.1 but it is not installable or
                   ruby2.0 but it is not installable or
                   libopenssl-ruby1.9.1 but it is not installable
          Depends: ruby2.1 but it is not installable or
                   ruby2.0 but it is not installable or
                   libreadline-ruby1.9.1 but it is not installable
          Depends: ruby2.1 but it is not installable or
                   ruby2.0 but it is not installable or
                   ruby1.9.1 but it is not installable
E: Unable to correct problems, you have held broken packages.
$ lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux testing (stretch)
Release:    testing
Codename:   stretch

@nikolai-b
Copy link

👍 Looks like the ruby virtual package is in old Ubuntu and Debian repos
as #1860 (comment) said.
I was getting this with debain sid also.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet