Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Check available space before writing #1400

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrey-kashcheev
Copy link
Collaborator

Try to check available space before writing to ensure that we could rollback from 'no space left' situation as leveldb requires space even for delete operations.

Relates-To: OAM-2013

Try to check available space before writing to ensure that we could
rollback from 'no space left' situation as leveldb requires space even
for delete operations.

Relates-To: OAM-2013
Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #1400 (dbabae2) into master (3c5794f) will decrease coverage by 0.01%.
The diff coverage is 73.91%.

❗ Current head dbabae2 differs from pull request most recent head 4c22461. Consider uploading reports for the commit 4c22461 to get more accurate results

@@            Coverage Diff             @@
##           master    #1400      +/-   ##
==========================================
- Coverage   80.71%   80.70%   -0.01%     
==========================================
  Files         337      337              
  Lines       12600    12624      +24     
  Branches     1360     1363       +3     
==========================================
+ Hits        10170    10188      +18     
- Misses       1881     1887       +6     
  Partials      549      549              
Impacted Files Coverage Δ
olp-cpp-sdk-core/src/cache/DiskCache.cpp 56.04% <73.91%> (+1.49%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant