Add asynchronous methods for GetLatestVersion functionality #1306

dudnyk · 2022-01-25T19:37:35Z

Creation of asynchronous methods is a part of task
continuation changes, later will be used in asynchronous
GetVersion method. GetVersion is not added in this commit
as it's in the private section and cannot be covered with tests.

Add asynchronous version of GetLatestVersion method
which handles the logic of getting data from cache/network.
Add asynchronous version of GetLatestCatalogVersion.
Move common functionality of getting data from the cache
and storing data returned from a request to the cache
to the RetrieveLatestVersion function.

Add unit tests which cover asynchronous methods for getting
the latest version.
Replaced mock expectation arguments with WithoutArgs.

Relates-To: OLPEDGE-2718

Signed-off-by: Yevhenii Dudnyk ext-yevhenii.dudnyk@here.com

codecov · 2022-01-25T19:52:29Z

Codecov Report

Merging #1306 (529fa85) into master (b1cd55b) will increase coverage by 0.1%.
The diff coverage is 98.8%.

❗ Current head 529fa85 differs from pull request most recent head 20d7ec1. Consider uploading reports for the commit 20d7ec1 to get more accurate results

@@           Coverage Diff            @@
##           master   #1306     +/-   ##
========================================
+ Coverage    86.1%   86.2%   +0.1%     
========================================
  Files         381     381             
  Lines       13425   13497     +72     
========================================
+ Hits        11565   11636     +71     
- Misses       1860    1861      +1

Impacted Files	Coverage Δ
...aservice-read/src/repositories/CatalogRepository.h	`100.0% <ø> (ø)`
...ervice-read/src/repositories/CatalogRepository.cpp	`99.3% <98.5%> (-0.7%)`	⬇️
...dataservice-read/src/generated/api/MetadataApi.cpp	`72.4% <100.0%> (+5.0%)`	⬆️
...ice-read/src/repositories/CatalogCacheRepository.h	`100.0% <0.0%> (ø)`
...clude/olp/dataservice/read/CatalogVersionRequest.h	`95.8% <0.0%> (+0.6%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cd55b...20d7ec1. Read the comment docs.

olp-cpp-sdk-dataservice-read/src/generated/api/MetadataApi.cpp

olp-cpp-sdk-dataservice-read/src/generated/api/MetadataApi.h

olp-cpp-sdk-dataservice-read/src/repositories/CatalogRepository.cpp

olp-cpp-sdk-dataservice-read/tests/CatalogRepositoryTest.cpp

olp-cpp-sdk-dataservice-read/src/repositories/CatalogRepository.cpp

olp-cpp-sdk-dataservice-read/src/generated/api/MetadataApi.cpp

olp-cpp-sdk-dataservice-read/tests/CatalogRepositoryTest.cpp

Creation of asynchronous methods is a part of task continuation changes, later will be used in asynchronous GetVersion method. GetVersion is not added in this commit as it's in the private section and cannot be covered with tests. Add asynchronous version of GetLatestVersion method which handles the logic of getting data from cache/network. Add asynchronous version of GetLatestCatalogVersion. Move common functionality of getting data from the cache and storing data returned from a request to the cache to the RetrieveLatestVersion function. Add unit tests which cover asynchronous methods for getting the latest version. Replaced mock expectation arguments with WithoutArgs. Relates-To: OLPEDGE-2718 Signed-off-by: Yevhenii Dudnyk <ext-yevhenii.dudnyk@here.com>

mykolamalik · 2022-02-07T09:51:50Z

olp-cpp-sdk-dataservice-read/src/generated/api/MetadataApi.h

+  static client::CancellationToken GetLatestCatalogVersion(
+      const client::OlpClient& client, int64_t start_version,
+      boost::optional<std::string> billing_tag,
+      read::CatalogVersionCallback callback);


Suggested change

read::CatalogVersionCallback callback);

CatalogVersionCallback callback);

mykolamalik · 2022-02-07T10:31:58Z

olp-cpp-sdk-dataservice-read/src/repositories/CatalogRepository.cpp

+      }
+    }
+
+    return std::move(version_response);


pessimizing-move
More info: https://stackoverflow.com/questions/62061433/how-to-avoid-the-pessimizing-move-warning-of-nrvo

Suggested change

return std::move(version_response);

return version_response;

mykolamalik · 2022-02-07T10:32:07Z

olp-cpp-sdk-dataservice-read/src/repositories/CatalogRepository.cpp

+    version_response = std::move(*cached_version);
+  }
+
+  return std::move(version_response);


pessimizing-move
More info: https://stackoverflow.com/questions/62061433/how-to-avoid-the-pessimizing-move-warning-of-nrvo

Suggested change

return std::move(version_response);

return version_response;

mykolamalik · 2022-02-07T10:36:11Z

olp-cpp-sdk-dataservice-read/tests/CatalogRepositoryTest.cpp

@@ -91,8 +98,7 @@ class CatalogRepositoryTest : public ::testing::Test {
    settings_.network_request_handler = network_;
    settings_.cache = cache_;

-    lookup_client_ =
-        std::make_shared<olp::client::ApiLookupClient>(kHrn, settings_);
+    lookup_client_ = std::make_shared<client::ApiLookupClient>(kHrn, settings_);


There is a distinct using for this one.

Suggested change

lookup_client_ = std::make_shared<client::ApiLookupClient>(kHrn, settings_);

lookup_client_ = std::make_shared<ApiLookupClient>(kHrn, settings_);

mykolamalik · 2022-02-07T10:36:32Z

olp-cpp-sdk-dataservice-read/tests/CatalogRepositoryTest.cpp

-  olp::client::OlpClientSettings settings_;
-  std::shared_ptr<olp::client::ApiLookupClient> lookup_client_;
+  client::OlpClientSettings settings_;
+  std::shared_ptr<client::ApiLookupClient> lookup_client_;


Suggested change

std::shared_ptr<client::ApiLookupClient> lookup_client_;

std::shared_ptr<ApiLookupClient> lookup_client_;

mykolamalik · 2022-02-07T10:41:22Z

olp-cpp-sdk-dataservice-read/tests/CatalogRepositoryTest.cpp

-  olp::client::CancellationContext context;
+TEST_F(CatalogRepositoryTest, AsyncGetLatestVersionOnlineOnlyForbidden) {
+  const auto request =
+      read::CatalogVersionRequest().WithFetchOption(read::OnlineIfNotFound);


You have OnlineIfNotFound request, but the name of the test contains OnlineOnly. Also, line 316 contains a mention of OnlineOnly.

mykolamalik · 2022-02-07T10:44:48Z

olp-cpp-sdk-dataservice-read/tests/CatalogRepositoryTest.cpp

+}
+
+TEST_F(CatalogRepositoryTest, AsyncGetLatestVersionOnlineOnlyUserCancelled2) {
+  const auto request = read::CatalogVersionRequest();


A default fetch option is OnlineIfNotFound. But the test name contains OnlineOnly

dudnyk force-pushed the task/olpedge-2718 branch from 7fe7b02 to c1c638e Compare January 26, 2022 08:50

dudnyk changed the title ~~Task/olpedge 2718~~ Add GetVersionOnline method Jan 26, 2022

dudnyk force-pushed the task/olpedge-2718 branch 15 times, most recently from afd16fe to 21d435a Compare February 1, 2022 09:49

dudnyk changed the title ~~Add GetVersionOnline method~~ Add asynchronous methods for GetLatestVersion functionality Feb 1, 2022

dudnyk force-pushed the task/olpedge-2718 branch 2 times, most recently from 0c57b8f to e93ebbc Compare February 1, 2022 09:54

mykolamalik requested changes Feb 2, 2022

View reviewed changes

dudnyk force-pushed the task/olpedge-2718 branch 3 times, most recently from 27bc9ff to aba52e9 Compare February 3, 2022 08:48

mykolamalik requested changes Feb 3, 2022

View reviewed changes

dudnyk force-pushed the task/olpedge-2718 branch 2 times, most recently from 9b268e8 to 1ea88ec Compare February 4, 2022 16:15

mykolamalik reviewed Feb 4, 2022

View reviewed changes

dudnyk force-pushed the task/olpedge-2718 branch from 1ea88ec to 91318f5 Compare February 6, 2022 08:17

dudnyk force-pushed the task/olpedge-2718 branch from 91318f5 to 8db431e Compare February 7, 2022 09:06

dudnyk requested a review from mykolamalik February 7, 2022 09:31

dudnyk force-pushed the task/olpedge-2718 branch from 8db431e to 20d7ec1 Compare February 7, 2022 09:51

mykolamalik requested changes Feb 7, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add asynchronous methods for GetLatestVersion functionality #1306

Add asynchronous methods for GetLatestVersion functionality #1306

dudnyk commented Jan 25, 2022 •

edited

codecov bot commented Jan 25, 2022 •

edited

mykolamalik Feb 7, 2022

mykolamalik Feb 7, 2022

mykolamalik Feb 7, 2022

mykolamalik Feb 7, 2022

mykolamalik Feb 7, 2022

mykolamalik Feb 7, 2022

mykolamalik Feb 7, 2022

	read::CatalogVersionCallback callback);
	CatalogVersionCallback callback);

	lookup_client_ = std::make_shared<client::ApiLookupClient>(kHrn, settings_);
	lookup_client_ = std::make_shared<ApiLookupClient>(kHrn, settings_);

	std::shared_ptr<client::ApiLookupClient> lookup_client_;
	std::shared_ptr<ApiLookupClient> lookup_client_;

Add asynchronous methods for GetLatestVersion functionality #1306

Are you sure you want to change the base?

Add asynchronous methods for GetLatestVersion functionality #1306

Conversation

dudnyk commented Jan 25, 2022 • edited

codecov bot commented Jan 25, 2022 • edited

Codecov Report

mykolamalik Feb 7, 2022

Choose a reason for hiding this comment

mykolamalik Feb 7, 2022

Choose a reason for hiding this comment

mykolamalik Feb 7, 2022

Choose a reason for hiding this comment

mykolamalik Feb 7, 2022

Choose a reason for hiding this comment

mykolamalik Feb 7, 2022

Choose a reason for hiding this comment

mykolamalik Feb 7, 2022

Choose a reason for hiding this comment

mykolamalik Feb 7, 2022

Choose a reason for hiding this comment

dudnyk commented Jan 25, 2022 •

edited

codecov bot commented Jan 25, 2022 •

edited