Adding support for Cost, Accuracy and SpeedUp in report for Multi-Alts #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 25, 2024 17:58
pavpanchekha
approved these changes
May 15, 2024
|
Minor nits only. Does it look OK? If so I'm happy to merge. |
added 2 commits
May 15, 2024 14:26
|
What are we waiting for to merge? |
|
@JPepperwood123 What are we waiting for to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the last of the two PRs that involve altering the report page.
While the first one was exclusively about displaying the graphs on the report page, this one included changes in 3 big places
The Accuracy vs Speed graph which didn't generate points for the Developer Targets now supports it
The Developer Targets on the report weren't hyperlinked and their individual Accuracy and Speedup weren't being calculated correctly - now being supported.
The .../graphs/ Results page was also erroneous. The summarizing graphs were displaying incorrect values and the target summary was also incorrect - with the change being made from a singular or no target to a list of target. A design decision of choosing the best target was made here to support the aesthetic.