Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate sampling code from Herbie #804

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

pavpanchekha
Copy link
Contributor

@pavpanchekha pavpanchekha commented May 13, 2024

This PR is attempting to isolate the sampling code (at least compile-specs but ideally also make-search-func and ival-eval) from Herbie infrastructure, so that it can eventually be moved into Rival. Long term, I think the goal is to have the following three main methods:

  • rival-compile, an analog of make-search-func
  • rival-apply, an analog of ival-eval
  • rival-analyze, an analog of search-step

Isolating all this code will require at least:

  • Remove dependence on operator-info
  • Remove dependence on timeline
  • Remove dependence on ulps-between
  • Remove use of compile-specs in accelerator.rkt

@pavpanchekha
Copy link
Contributor Author

Update: I've added all the abstraction layers I want, and made all of the Herbie methods we know and love/hate go through them. Right now there's a bit of confusing mis-layering in how preconditions are handled, but if that is fixed I think we'll have a pretty clean API and I can move most of the key methods into correct-round.rkt and start isolating in order to move things to Rival.

@pavpanchekha
Copy link
Contributor Author

The most recent nightly has way more invalid 0 points and way more exit points. Plus, localize is way slower. That has to be fixed before merging, we can't have performance regressions! But at least it runs to completion, which is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant