-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate sampling code from Herbie #804
base: main
Are you sure you want to change the base?
Conversation
Update: I've added all the abstraction layers I want, and made all of the Herbie methods we know and love/hate go through them. Right now there's a bit of confusing mis-layering in how preconditions are handled, but if that is fixed I think we'll have a pretty clean API and I can move most of the key methods into |
This required losing two unit tests
The most recent nightly has way more |
This PR is attempting to isolate the sampling code (at least
compile-specs
but ideally alsomake-search-func
andival-eval
) from Herbie infrastructure, so that it can eventually be moved into Rival. Long term, I think the goal is to have the following three main methods:rival-compile
, an analog ofmake-search-func
rival-apply
, an analog ofival-eval
rival-analyze
, an analog ofsearch-step
Isolating all this code will require at least:
operator-info
timeline
ulps-between
compile-specs
inaccelerator.rkt