Safe sampling feature #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AYadrov
commented
May 14, 2024
| (vector-copy! vprecs 0 vprecs-new) | ||
|
|
||
| ; Step 5. If precisions have not changed but the point didn't converge. A problem exists - add slack to every op | ||
| (when (false? (vector-member #f vrepeats)) |
There was a problem hiding this comment.
if all the precisions are not higher than from previous run
There was a problem hiding this comment.
The code is odd but whatever.
pavpanchekha
approved these changes
May 15, 2024
| (vector-copy! vprecs 0 vprecs-new) | ||
|
|
||
| ; Step 5. If precisions have not changed but the point didn't converge. A problem exists - add slack to every op | ||
| (when (false? (vector-member #f vrepeats)) |
There was a problem hiding this comment.
The code is odd but whatever.
| [n (in-range (vector-length vprecs))]) | ||
| (define prec* (min (*max-mpfr-prec*) (+ prec slack))) | ||
| (when (equal? prec* (*max-mpfr-prec*)) (*sampling-iteration* (*max-sampling-iterations*))) | ||
| (vector-set! vprecs n prec*)))) |
There was a problem hiding this comment.
I would love it if this logged somewhere, but fine.
| @@ -26,7 +26,7 @@ | |||
| ;; The first element of that function's output tells you if the input is good | |||
| ;; The other elements of that function's output tell you the output values | |||
| (define (make-search-func pre specs ctxs) | |||
| (define fns (compile-specs (cons pre specs) (context-vars (car ctxs)))) | |||
| (define fns (compile-specs (cons pre specs) (context-vars (car ctxs)) (context-repr (car ctxs)))) | |||
There was a problem hiding this comment.
I think this actually also maybe isn't quite right, since it assumes all outputs use the same repr. This won't be correct if an expression uses mixed binary32/binary64 code. That said, I'm not too worried about this because I think it'll need to be fixed a different way anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch introduces a new feature for sampling which makes sampling safer if an unknown problem exists.
This feature checks whether all the precisions of an expressions have not increased. If this is true - then add slack to every operation.
The feature is pretty simple but can save few points where an unhandled problem occurred.
The branch also fixes small issues as: measuring ulp distance in backward pass with respect to
reprinstead of relying onfloat, and miscalculating exponent ofmin.bfinlog2-approx