Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue-300): template path translation #338

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented May 12, 2024

WIP for issue #300

  • optimise function getFiles from N^2 to N. This optimization should improve performance and memory usage of the function

Instead of initializing filesSet with a capacity, it's now initialized as an empty slice (var filesSet []string). This avoids reallocating the underlying array when appending elements.

The problem is identified

when running all tests

the path is template "with-subchart/charts/child-chart/templates/deployment.yaml"
Screenshot 2024-05-12 at 15 19 07

when running specific test

the path is template "with-subchart/templates/deploymentent.yaml"

Screenshot 2024-05-12 at 15 19 43

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk ivankatliarchuk marked this pull request as draft May 12, 2024 12:09
@ivankatliarchuk ivankatliarchuk changed the title fix(issue-300): initial commit fix(issue-300): template path translation May 12, 2024
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant