-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.x: Helidon Services #8400
Draft
tomas-langer
wants to merge
81
commits into
helidon-io:main
Choose a base branch
from
tomas-langer:inject
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
5.x: Helidon Services #8400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Feb 20, 2024
Rebased |
Switch to Builder codegen Use Builder API for all Blueprints Use new builder codegen in all of Helidon Fixes needed after upgrading checkstyle. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
* Introduction of Helidon Inject Service module. Signed-off-by: Tomas Langer <tomas.langer@oracle.com> Co-authored-by: Jeff Trent <jeff.trent@oracle.com>
…elidon-io#8149) * Introduction of codegen modules to all injection related areas. * Inercepted type and constructor should be package private Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
* Introduction of helidon-inject, helidon-inject-configdriven, and helidon-inject-configdriven-services * Aligned method names on `Services` with other containers, such as `Parameters` and `Headers` Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
* Refactored inject maven-plugin * Fixed most of build issues. * Flag to control whether to generate META-INF/services * Added support for InjectionServices that are not singleton * Handle generation of module component after last type is generated, rather than in processingOver, to avoid a warning * Introduced ServiceProviderRegistry.java * Validating helidon prefixed options * Config bean registry is no longer a singleton, to support parallel build Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
* Using new modules in all of Helidon * Removed modules no longer in use. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
…idon-inject (and use only user's dependencies). Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
External jar maven plugin Tests for registry and injection All tests passing Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
…ect equals and hash code. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Support for service discovery of Java ServiceLoader services. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
spericas
reviewed
Mar 12, 2024
service/registry/src/main/java/io/helidon/service/registry/ServiceRegistryManagerDiscovery.java
Show resolved
Hide resolved
service/registry/src/main/java/io/helidon/service/registry/CoreServiceDiscovery.java
Outdated
Show resolved
Hide resolved
service/registry/src/main/java/io/helidon/service/registry/CoreServiceRegistryManager.java
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/Injection.java
Outdated
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/Injection.java
Outdated
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/Injection.java
Outdated
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/Injection.java
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/Injection.java
Outdated
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/Interception.java
Outdated
Show resolved
Hide resolved
service/inject/api/src/main/java/io/helidon/service/inject/api/ConfigDriven.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
- DrivenBy is now CreateFor - DrivenByName is now CreateForName - A few text fixes Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Added suppress warnings for unchecked casts to instantiate and inject methods when needed Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Shutdown handler logic moved to a single place - io.helidon.Main Refactored all usages Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Fixed all discovered issues with fallbacks and injection. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
…ice discovery. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7957
Resolves #6647
Resolves #5697
Resolves #8222
Resolves #7083
Resolves #7052
Resolves #6768
Resolves #6646
Resolves #6620
Description
Helidon services provides a replacement for service loader with some additional features - module
helidon-service-registry
In addition we have a module with full injection, config driven, and interception support -
helidon-service-inject-api
andhelidon-service-inject
(API and implementation)Best place to check the features and generated code is in the
service/tests
andservice/tests/inject
modules.The PR contains also initial code for Helidon declarative, though that is not yet fully done.
This PR is ready for review of the concepts, generated code, module structure (service module and its children).
Removed the requirement to modify
module-info.java
by the user, as we use our own way of discovering and loading services.Request scope is now an optional feature even when using HTTP. This is achieved by compile time extension to support parameters through source code + additional set of services that support the same using request scope
Known Todos
io.helidon.Main
)service-codegen
, as it still uses the old inject based namingNew stuff unrelated to services
service
module uses dependency checking maven pluginservice
module is configured to fail on javadoc warning