Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rolling option #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sobrinho
Copy link
Contributor

Legacy applications want to migrate from SHA1 to SHA512, for example.

Inspired in what Authlogic has with transition_from_crypto_providers.

@sobrinho
Copy link
Contributor Author

It probably makes sense to have a BCrypt cryptor now to be able to migrate from sha1 or any encryptor from this gem to the "new encryptor" that Devises uses these days.

If we agree in this PR, I can do another one to be able to support that rolling or even include in this one.

@sobrinho
Copy link
Contributor Author

Merging #20 we can rebase this to merge cleanly.

@pboling
Copy link

pboling commented Jan 24, 2022

@sobrinho This is awesome. Any chance of this making it into a release? Would love to be able to roll from bcrypt to argon2id

ref: https://www.monterail.com/blog/more-secure-passwords-bcrypt

@sobrinho sobrinho force-pushed the rolling-encryptor branch 2 times, most recently from ad3c062 to 81fbeb3 Compare January 24, 2022 19:09
@sobrinho
Copy link
Contributor Author

PR updated.

@pboling
Copy link

pboling commented Jan 25, 2022

@carlosantoniodasilva thoughts?

@vaot
Copy link

vaot commented Jan 19, 2023

@sobrinho This is great. Is there any interest in merging this one ? We would love to have this option to move from bcrypt.

@sobrinho
Copy link
Contributor Author

PR rebased!

The build is broken for another reason on 3.0 rails main and 2.7 rails main.

@carlosantoniodasilva feel free to merge this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants