Add ZGC bean names to support GC stats #26329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hz-devops-test
added
the
Source: Community
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
|
|
Can one of the admins verify this patch? |
RobbanHoglund
changed the title
|
Internal PR hazelcast/hazelcast-mono#1855 |
RobbanHoglund
force-pushed
the
update_gcstats
branch
from
3dd493b
to
66a2cdf
Compare
fawazghali
requested review from
frant-hartm,
SeriyBg and
srknzl
and removed request for
SeriyBg
srknzl
approved these changes
May 17, 2024
|
Also see https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/gc/z/TestGarbageCollectorMXBean.java, maybe source code of jdk is good enough as well |
frant-hartm
changed the title
frant-hartm
approved these changes
May 17, 2024
devOpsHazelcast
pushed a commit
that referenced
this pull request
May 20, 2024
Import of #26329 **Original PR description:** The ZGC Garbage collector is not recognized since the "ZGC" name does not match the actual name/names. In the metrics it will be named as "unknown". This fix will match the actual ZGC names. Imported changes: - 66a2cdf Add proper ZGC support and renaming of internal set Closes #26329 --------- Co-authored-by: Robert Höglund <robban.hoglund@gmail.com> Co-authored-by: Serkan Özel <serkan.ozel@hazelcast.com> GitOrigin-RevId: db7d086b7c10b0ef130533dd51680673c9397b5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZGC Garbage collector is not recognized since the "ZGC" name does not match the actual name/names. In the metrics it will be named as "unknown". This fix will match the actual ZGC names.
Fixes: N/A
Backport of: N/A
Breaking changes (list specific methods/types/messages):
I renamed these internal sets:
public static final Set YOUNG_GC; -> MINOR_GC
public static final Set OLD_GC; -> MAJOR_GC
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release Noteslabel if changes should be mentioned in release notes orNot Release Notes contentif changes are not relevant for release notes@Nonnull/@Nullableannotations@sincetags in Javadoc